Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1420283019: [runtime] Remove obsolete %_StringAdd intrinsic. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove obsolete %_StringAdd intrinsic. The %_StringAdd intrinsic is not used anymore, so no need to keep the code around. R=yangguo@chromium.org Committed: https://crrev.com/de9ebd82d011bcaaa9488cfdac6b5c2e5d68a2c4 Cr-Commit-Position: refs/heads/master@{#31822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -123 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-05 11:57:57 UTC) #1
Benedikt Meurer
Hey Yang, Dead code should be dead! Red-only! Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-05 11:58:49 UTC) #2
Yang
lgtm!
5 years, 1 month ago (2015-11-05 12:00:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283019/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283019/1
5 years, 1 month ago (2015-11-05 12:00:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 12:16:49 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 12:17:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de9ebd82d011bcaaa9488cfdac6b5c2e5d68a2c4
Cr-Commit-Position: refs/heads/master@{#31822}

Powered by Google App Engine
This is Rietveld 408576698