Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1420283011: [css-flexbox] Make min-size:auto work correctly with an explicit width on the flex item (Closed)

Created:
5 years, 1 month ago by cbiesinger
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, tfarina, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Make min-size:auto work correctly with an explicit width on the flex item This was a silly typo in the original change (https://codereview.chromium.org/1421423005) Found by running the CSSWG test suite. Adding the test that found it until we import the full suite. R=leviw@chromium.org BUG=546034 Committed: https://crrev.com/e07c0a227e36b4fefbf0927633c404f2606a4ed4 Cr-Commit-Position: refs/heads/master@{#357004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/imported/flexbox_direction-row-reverse.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/css3/flexbox/imported/flexbox_direction-row-reverse-expected.html View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
cbiesinger
5 years, 1 month ago (2015-10-29 20:40:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283011/1
5 years, 1 month ago (2015-10-29 20:41:21 UTC) #3
leviw_travelin_and_unemployed
D'oh! Thanks, Christian. LGTM.
5 years, 1 month ago (2015-10-29 20:48:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283011/1
5 years, 1 month ago (2015-10-29 20:49:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/127875)
5 years, 1 month ago (2015-10-29 22:58:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283011/1
5 years, 1 month ago (2015-10-29 23:58:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 00:53:42 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:54:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e07c0a227e36b4fefbf0927633c404f2606a4ed4
Cr-Commit-Position: refs/heads/master@{#357004}

Powered by Google App Engine
This is Rietveld 408576698