Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1420283009: [turbofan] Add support for storing to double fields. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for storing to double fields. Adds new Guard[Type] common operator, which takes value and control inputs and records a guaranty that a certain value has a certain type in that control path. This is some kind of ad-hoc SSI similar to what we have to do in Crankshaft in some places. Also introduces an ObjectIsNumber simplified operator, which checks whether a certain value is a number (either a Smi or a HeapNumber). This doesn't yet support transitioning stores to double fields, which require support for allocating mutable heap numbers. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/0df0e254a380edb019fb2a85acd6e562b6309598 Cr-Commit-Position: refs/heads/master@{#31675}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -31 lines) Patch
M src/compiler/common-operator.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/common-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +30 lines, -22 lines 3 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +43 lines, -9 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-29 12:40:24 UTC) #1
Benedikt Meurer
Hey Jaro, This is the initial patch for double stores. Please take a look. Thanks, ...
5 years, 1 month ago (2015-10-29 12:42:17 UTC) #2
Jarin
https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc#newcode687 src/compiler/js-native-context-specialization.cc:687: field_access.name = MaybeHandle<Name>(); I am confused, are we going ...
5 years, 1 month ago (2015-10-30 10:05:13 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc#newcode687 src/compiler/js-native-context-specialization.cc:687: field_access.name = MaybeHandle<Name>(); Yes, when double field unboxing is ...
5 years, 1 month ago (2015-10-30 10:07:19 UTC) #4
Jarin
lgtm https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1420283009/diff/1/src/compiler/js-native-context-specialization.cc#newcode687 src/compiler/js-native-context-specialization.cc:687: field_access.name = MaybeHandle<Name>(); On 2015/10/30 10:07:19, Benedikt Meurer ...
5 years, 1 month ago (2015-10-30 10:11:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420283009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420283009/1
5 years, 1 month ago (2015-10-30 10:11:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 10:19:21 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:19:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0df0e254a380edb019fb2a85acd6e562b6309598
Cr-Commit-Position: refs/heads/master@{#31675}

Powered by Google App Engine
This is Rietveld 408576698