Issue 1420273011: Side effect characterization of String.fromCharCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1420273011: Side effect characterization of String.fromCharCode (Closed)

Created:
5 years, 1 month ago by sra1

Modified:
5 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Side effect characterization of String.fromCharCode This allows dart2js to determine 'Primitive_stringFromCharCode' is effect free. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/f7a39a62411fa93fc45d37970db1c4b9f79a46f8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

5 years, 1 month ago (2015-11-05 18:36:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f7a39a62411fa93fc45d37970db1c4b9f79a46f8 (presubmit successful).