Add TransportSession interface to prepare for WebRTC-based transport.

remoting/protocol/fake_session.cc

Index: remoting/protocol/fake_session.cc
diff --git a/remoting/protocol/fake_session.cc b/remoting/protocol/fake_session.cc
index e21f932a4118da74b114ceb86cd60cb3b65c8d50..9e7d8fcc5da2e94d60b5c8f8042d48f7fe6da68f 100644
--- a/remoting/protocol/fake_session.cc
+++ b/remoting/protocol/fake_session.cc
@@ -9,6 +9,33 @@ namespace protocol {
 
 const char kTestJid[] = "host1@gmail.com/chromoting123";
 
+FakeTransportSession::FakeTransportSession() {}
+FakeTransportSession::~FakeTransportSession() {}
+
+void FakeTransportSession::Start(EventHandler* event_handler,
+                                 Authenticator* authenticator) {
+  NOTREACHED();
+}
+
+bool FakeTransportSession::ProcessTransportInfo(
+    buzz::XmlElement* transport_info) {
+  NOTREACHED();
+  return true;
+}
+
+DatagramChannelFactory* FakeTransportSession::GetDatagramChannelFactory() {
+  NOTIMPLEMENTED();

[Jamie, 2015/10/27 21:32:27]

Why NOTIMPLEMENTED for this method vs. NOTREACHED for the others?

[Sergey Ulanov, 2015/10/27 23:03:58]

Potentially we could implement GetDatagramChannelFactory() if some tests needed
it.
Start() and ProcessTransportInfo() are intended to be called by the session
signaling layer, i.e. FakeSession, but FakeSession doesn't call these methods,
so it wouldn't make sense to implement Start() and ProcessTransportInfo() as
long as FakeTransportSession is created only by FakeSession.

+  return nullptr;
+}
+
+FakeStreamChannelFactory* FakeTransportSession::GetStreamChannelFactory() {
+  return &channel_factory_;
+}
+
+FakeStreamChannelFactory* FakeTransportSession::GetMultiplexedChannelFactory() {
+  return &channel_factory_;
+}
+
 FakeSession::FakeSession()
     : event_handler_(nullptr),
       config_(SessionConfig::ForTest()),
@@ -34,16 +61,12 @@ const SessionConfig& FakeSession::config() {
   return *config_;
 }
 
-StreamChannelFactory* FakeSession::GetTransportChannelFactory() {
-  return &channel_factory_;
+FakeTransportSession* FakeSession::GetTransportSession() {
+  return &transport_session_;
 }
 
-StreamChannelFactory* FakeSession::GetMultiplexedChannelFactory() {
-  return &channel_factory_;
-}
-
-StreamChannelFactory* FakeSession::GetQuicChannelFactory() {
-  return &channel_factory_;
+FakeStreamChannelFactory* FakeSession::GetQuicChannelFactory() {
+  return transport_session_.GetStreamChannelFactory();
 }
 
 void FakeSession::Close() {