Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420233002: X87: Added Popcnt as an optional operator and implement it on x64 and ia32. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Added Popcnt as an optional operator and implement it on x64 and ia32. port 053e280c881724e69e4a83b85738dd4c5a3aac9c (r31319). original commit message: BUG= Committed: https://crrev.com/1e52cd528212583ea554c28e90372aac82aa0908 Cr-Commit-Position: refs/heads/master@{#31541}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/x87/macro-assembler-x87.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 10:23:21 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 10:59:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420233002/1
5 years, 2 months ago (2015-10-23 10:59:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9963)
5 years, 2 months ago (2015-10-23 12:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420233002/1
5 years, 2 months ago (2015-10-23 14:59:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7025)
5 years, 2 months ago (2015-10-23 15:01:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420233002/20001
5 years, 1 month ago (2015-10-26 03:06:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 03:29:11 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 03:29:46 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1e52cd528212583ea554c28e90372aac82aa0908
Cr-Commit-Position: refs/heads/master@{#31541}

Powered by Google App Engine
This is Rietveld 408576698