Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142023008: [PPAPI][MediaStream] Rename AudioFrame to AudioBuffer (Closed)

Created:
6 years, 10 months ago by Peng
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[PPAPI][MediaStream] Rename AudioFrame to AudioBuffer For audio, a frame usually has the same meaning as sample, so AudioFrame is not a good name for a bunch of audio samples. Change it to AudioBuffer. This CL only changes the name in base classes. The API interface will be changed in a separate CL. BUG=330851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249919

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix review issues #

Patch Set 3 : Fix review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -542 lines) Patch
M content/renderer/pepper/pepper_media_stream_audio_track_host.h View 1 4 chunks +21 lines, -17 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_audio_track_host.cc View 1 8 chunks +40 lines, -40 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_track_host_base.h View 3 chunks +11 lines, -10 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_track_host_base.cc View 5 chunks +21 lines, -18 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M ppapi/examples/media_stream_video/media_stream_video.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/proxy/audio_frame_resource.h View 3 chunks +8 lines, -6 lines 0 comments Download
M ppapi/proxy/audio_frame_resource.cc View 3 chunks +33 lines, -32 lines 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/proxy/media_stream_track_resource_base.h View 3 chunks +14 lines, -13 lines 0 comments Download
M ppapi/proxy/media_stream_track_resource_base.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M ppapi/proxy/media_stream_video_track_resource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/media_stream_video_track_resource.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M ppapi/proxy/video_frame_resource.h View 3 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/video_frame_resource.cc View 2 chunks +21 lines, -21 lines 0 comments Download
A + ppapi/shared_impl/media_stream_buffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/media_stream_buffer_manager.h View 2 chunks +45 lines, -44 lines 0 comments Download
A + ppapi/shared_impl/media_stream_buffer_manager.cc View 1 chunk +36 lines, -34 lines 0 comments Download
D ppapi/shared_impl/media_stream_frame.h View 1 chunk +0 lines, -62 lines 0 comments Download
D ppapi/shared_impl/media_stream_frame_buffer.h View 1 chunk +0 lines, -93 lines 0 comments Download
D ppapi/shared_impl/media_stream_frame_buffer.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M ppapi/thunk/ppb_audio_frame_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_video_frame_api.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Peng
I renamed frame in MediaStream API Audio part to buffer. Please take a look. Thanks. ...
6 years, 10 months ago (2014-02-06 19:26:19 UTC) #1
yzshen1
https://codereview.chromium.org/142023008/diff/1/content/renderer/pepper/pepper_media_stream_audio_track_host.h File content/renderer/pepper/pepper_media_stream_audio_track_host.h (right): https://codereview.chromium.org/142023008/diff/1/content/renderer/pepper/pepper_media_stream_audio_track_host.h#newcode47 content/renderer/pepper/pepper_media_stream_audio_track_host.h:47: // Init buffers on the main thread. Please use ...
6 years, 10 months ago (2014-02-07 20:09:52 UTC) #2
Peng
https://codereview.chromium.org/142023008/diff/1/content/renderer/pepper/pepper_media_stream_audio_track_host.h File content/renderer/pepper/pepper_media_stream_audio_track_host.h (right): https://codereview.chromium.org/142023008/diff/1/content/renderer/pepper/pepper_media_stream_audio_track_host.h#newcode47 content/renderer/pepper/pepper_media_stream_audio_track_host.h:47: // Init buffers on the main thread. On 2014/02/07 ...
6 years, 10 months ago (2014-02-07 20:30:00 UTC) #3
yzshen1
lgtm
6 years, 10 months ago (2014-02-07 22:20:16 UTC) #4
jschuh
looks like just a name changes with no security impact. rubberstamp lgtm.
6 years, 10 months ago (2014-02-07 22:41:44 UTC) #5
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-07 23:01:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/142023008/100001
6 years, 10 months ago (2014-02-07 23:03:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 02:10:14 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260226
6 years, 10 months ago (2014-02-08 02:10:14 UTC) #9
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-08 02:15:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/142023008/100001
6 years, 10 months ago (2014-02-08 02:16:47 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-08 03:20:18 UTC) #12
Message was sent while issue was closed. 
Change committed as 249919

Powered by Google App Engine
This is Rietveld 408576698