Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Issue 142023006: android envsetup: Stop explicitly setting host_arch when target_arch=x86. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, Yaron
Visibility:
Public.

Description

android envsetup: Stop explicitly setting host_arch when target_arch=x86. The explicit setting seems to match the default value for host_arch in build/common.gypi close to line 110, and it's not set explicitly for other target_archs, so this looks like an oversight. It's been this way since this file was added in r148790 18 months ago. No intended behavior change. BUG=330631 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 10 months ago (2014-01-31 01:36:20 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-01-31 10:41:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/142023006/1
6 years, 10 months ago (2014-01-31 10:47:14 UTC) #3
commit-bot: I haz the power
Change committed as 248188
6 years, 10 months ago (2014-01-31 14:10:46 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 14:10:53 UTC) #5
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698