Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1420223003: Stage ES2015-style const in sloppy mode (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage ES2015-style const in sloppy mode This patch switches sloppy-mode code from legacy const semantics to ES2015 semantics. It is unknown how much of the web will be broken by this; likely the patch will have to be reverted before a branch happens. BUG=v8:3739 LOG=Y R=rossberg,adamk Committed: https://crrev.com/0a0272dad09d35da2762baadc5b48c9d2b7f11ef Cr-Commit-Position: refs/heads/master@{#31525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420223003/1
5 years, 2 months ago (2015-10-23 11:17:57 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 12:28:07 UTC) #5
Dan Ehrenberg
5 years, 2 months ago (2015-10-23 13:28:25 UTC) #6
rossberg
lgtm
5 years, 2 months ago (2015-10-23 14:02:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420223003/1
5 years, 2 months ago (2015-10-23 14:02:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 14:04:32 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 14:05:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a0272dad09d35da2762baadc5b48c9d2b7f11ef
Cr-Commit-Position: refs/heads/master@{#31525}

Powered by Google App Engine
This is Rietveld 408576698