Disallow assigning a MediaSession after the resource has been selected

third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/mediasession/HTMLMediaElementMediaSession.h"
 
+#include "core/dom/ExceptionCode.h"
+
 namespace blink {
 
 MediaSession* HTMLMediaElementMediaSession::session(HTMLMediaElement& mediaElement)
 {
     if (HTMLMediaElementMediaSession* supplement = fromIfExists(mediaElement))
         return supplement->m_session.get();
     return nullptr;
 }
 
-void HTMLMediaElementMediaSession::setSession(HTMLMediaElement& mediaElement, MediaSession* session)
+void HTMLMediaElementMediaSession::setSession(HTMLMediaElement& mediaElement, MediaSession* session, ExceptionState& exceptionState)
 {
+    HTMLMediaElement::NetworkState networkState = mediaElement.networkState();
+    if (networkState == HTMLMediaElement::NETWORK_IDLE || networkState == HTMLMediaElement::NETWORK_LOADING) {
+        exceptionState.throwDOMException(InvalidStateError, "Media sessions must be assigned before a resource has been selected");

[philipj_slow, 2015/10/23 11:17:11]

Maybe say that the expected networkState is NETWORK_EMPTY or NETWORK_NO_SOURCE,
and also say what the actual networkState is? It has to be a pretty savvy web
developer to know about the resource selection algorithm and its connection to
networkState.

+        return;
+    }
+
     from(mediaElement).m_session = session;
 }
 
 const char* HTMLMediaElementMediaSession::supplementName()
 {
     return "HTMLMediaElementMediaSession";
 }
 
 HTMLMediaElementMediaSession& HTMLMediaElementMediaSession::from(HTMLMediaElement& element)
 {
@@ skipping 11 matching lines @@
 }
 
 DEFINE_TRACE(HTMLMediaElementMediaSession)
 {
     visitor->trace(m_session);
     WillBeHeapSupplement<HTMLMediaElement>::trace(visitor);
 }
 
 }