third_party/WebKit/LayoutTests/media/mediasession/htmlmediaelement-set-session.html - Issue 1420223002: Disallow assigning a MediaSession after the resource has been selected

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/mediasession/htmlmediaelement-set-session.html

Issue 1420223002: Disallow assigning a MediaSession after the resource has been selected (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.h » ('j') | third_party/WebKit/Source/modules/mediasession/HTMLMediaElementMediaSession.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>HTMLMediaElement set session</title>	2 <title>HTMLMediaElement set session</title>

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script>	5 <script>

6 test(function() {	6 test(function() {

7 assert_true(!window.internals \|\| window.internals.runtimeFlags.mediaSessio nEnabled,	7 assert_true(!window.internals \|\| window.internals.runtimeFlags.mediaSessio nEnabled,

8 "Run either manually by passing the MediaSession flag or as part of th e virtual mediasession testsuite.");	8 "Run either manually by passing the MediaSession flag or as part of th e virtual mediasession testsuite.");

9 console.warn("dummy log entry to avoid an empty -expected.txt in virtual/" );	9 console.warn("dummy log entry to avoid an empty -expected.txt in virtual/" );

10	10

11 var mediaElement = document.createElement('audio');	11 var mediaElement = document.createElement('audio');

12 assert_true(mediaElement instanceof HTMLMediaElement);	12 assert_true(mediaElement instanceof HTMLMediaElement);

13	13

14 var mediaSession = new MediaSession();	14 var mediaSession = new MediaSession();

15 mediaElement.session = mediaSession;	15 mediaElement.session = mediaSession;

16 assert_equals(mediaElement.session, mediaSession);	16 assert_equals(mediaElement.session, mediaSession);

17	17

18 assert_throws(new TypeError, function() { mediaElement.session = document; });	18 assert_throws(new TypeError, function() { mediaElement.session = document; });

19 assert_throws(new TypeError, function() { mediaElement.session = "string"; });	19 assert_throws(new TypeError, function() { mediaElement.session = "string"; });

20 assert_throws(new TypeError, function() { mediaElement.session = 42; });	20 assert_throws(new TypeError, function() { mediaElement.session = 42; });

21 assert_equals(mediaElement.session, mediaSession);	21 assert_equals(mediaElement.session, mediaSession);

22	22

23 mediaElement.session = null;	23 mediaElement.session = null;

24 assert_equals(mediaElement.session, null);	24 assert_equals(mediaElement.session, null);

	25

	26 mediaElement.src = '../resources/test-live.webm';

	27 mediaElement.load();
	philipj_slow 2015/10/23 11:17:11 Setting the src attribute should (per spec) alread Setting the src attribute should (per spec) already have run the media element load algorithm. You could assert that networkState is now NETWORK_NO_SOURCE. A separate test for NETWORK_EMPTY would also be nice, so I guess that would make three tests in total.
	28 assert_throws("InvalidStateError", function() { mediaElement.session = med iaSession; });

25 });	29 });

26 </script>	30 </script>

OLD	NEW