Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/status_icons/status_tray_unittest.cc

Issue 1420163003: Fixed Windows system tray icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@profile-icon-imagefamily
Patch Set: Revert changes to start in a delayed task. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/status_icons/status_tray_unittest.cc
diff --git a/chrome/browser/status_icons/status_tray_unittest.cc b/chrome/browser/status_icons/status_tray_unittest.cc
index 90f13299867181915606d1fca80d42d0b0667e09..0ab2a1f1f96b4c14523dfe5a438bee511e1b01b0 100644
--- a/chrome/browser/status_icons/status_tray_unittest.cc
+++ b/chrome/browser/status_icons/status_tray_unittest.cc
@@ -3,16 +3,15 @@
// found in the LICENSE file.
#include "base/compiler_specific.h"
-#include "base/strings/string_util.h"
-#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/status_icons/status_icon.h"
#include "chrome/browser/status_icons/status_tray.h"
-#include "grit/chrome_unscaled_resources.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/image/image_unittest_util.h"
#include "ui/message_center/notifier_settings.h"
+namespace {
+
class MockStatusIcon : public StatusIcon {
void SetImage(const gfx::ImageSkia& image) override {}
void SetToolTip(const base::string16& tool_tip) override {}
@@ -35,23 +34,26 @@ class TestStatusTray : public StatusTray {
const StatusIcons& GetStatusIconsForTest() const { return status_icons(); }
};
+StatusIcon* CreateStatusIcon(StatusTray* tray) {
+ // Just create a dummy icon image; the actual image is irrelevant.
+ return tray->CreateStatusIcon(StatusTray::OTHER_ICON,
+ gfx::test::CreateImageSkia(16, 16),
+ base::string16());
+}
+
+} // namespace
+
TEST(StatusTrayTest, Create) {
// Check for creation and leaks.
TestStatusTray tray;
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- gfx::ImageSkia* image = rb.GetImageSkiaNamed(IDR_STATUS_TRAY_ICON);
- tray.CreateStatusIcon(
- StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip"));
+ CreateStatusIcon(&tray);
EXPECT_EQ(1U, tray.GetStatusIconsForTest().size());
}
// Make sure that removing an icon removes it from the list.
TEST(StatusTrayTest, CreateRemove) {
TestStatusTray tray;
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- gfx::ImageSkia* image = rb.GetImageSkiaNamed(IDR_STATUS_TRAY_ICON);
- StatusIcon* icon = tray.CreateStatusIcon(
- StatusTray::OTHER_ICON, *image, base::ASCIIToUTF16("tool tip"));
+ StatusIcon* icon = CreateStatusIcon(&tray);
EXPECT_EQ(1U, tray.GetStatusIconsForTest().size());
tray.RemoveStatusIcon(icon);
EXPECT_EQ(0U, tray.GetStatusIconsForTest().size());

Powered by Google App Engine
This is Rietveld 408576698