Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1420143002: Revert of Move prefix_set and parts of s_b_util into a new component safe_browsing_db. (Closed)

Created:
5 years, 2 months ago by DaleCurtis
Modified:
5 years, 2 months ago
CC:
chromium-reviews, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, Jialiu Lin, gsennton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move prefix_set and parts of s_b_util into a new component safe_browsing_db. (patchset #7 id:120001 of https://codereview.chromium.org/1399843003/ ) Reason for revert: Broke the Windows x64 GN builders: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN&number=7560 Original issue's description: > Move prefix_set and parts of safe_browsing_util into a new component safe_browsing_db. > > This component will hold the new implementation for the > next version (pver4) of the update protocol and DB. > > BUG=543161 > > Committed: https://crrev.com/607ee298239a88fa0823c3aea10bcee83eff855a > Cr-Commit-Position: refs/heads/master@{#355654} TBR=nparker@chromium.org,noelutz@chromium.org,droger@chromium.org,thestig@chromium.org,blundell@chromium.org,rsleevi@chromium.org,vakh@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db Cr-Commit-Position: refs/heads/master@{#355659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6470 lines, -6568 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/safe_browsing/prefix_set.h View 1 chunk +186 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/prefix_set.cc View 1 chunk +448 lines, -0 lines 0 comments Download
A chrome/browser/safe_browsing/prefix_set_unittest.cc View 1 chunk +726 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 4 chunks +54 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/test/data/SafeBrowsing/PrefixSetRef View 1 chunk +5000 lines, -0 lines 0 comments Download
A chrome/test/data/SafeBrowsing/PrefixSetVersion2 View Binary file 0 comments Download
A chrome/test/data/SafeBrowsing/PrefixSetVersion3 View Binary file 0 comments Download
M components/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
D components/safe_browsing_db.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
D components/safe_browsing_db/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D components/safe_browsing_db/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/safe_browsing_db/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/safe_browsing_db/README View 1 chunk +0 lines, -3 lines 0 comments Download
D components/safe_browsing_db/prefix_set.h View 1 chunk +0 lines, -187 lines 0 comments Download
D components/safe_browsing_db/prefix_set.cc View 1 chunk +0 lines, -449 lines 0 comments Download
D components/safe_browsing_db/prefix_set_unittest.cc View 1 chunk +0 lines, -728 lines 0 comments Download
D components/safe_browsing_db/safe_browsing_db_util.h View 1 chunk +0 lines, -62 lines 0 comments Download
D components/safe_browsing_db/safe_browsing_db_util.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/safe_browsing_db/safe_browsing_db_util_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D components/test/data/SafeBrowsingDb/PrefixSetRef View 1 chunk +0 lines, -5000 lines 0 comments Download
D components/test/data/SafeBrowsingDb/PrefixSetVersion2 View Binary file 0 comments Download
D components/test/data/SafeBrowsingDb/PrefixSetVersion3 View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
DaleCurtis
Created Revert of Move prefix_set and parts of s_b_util into a new component safe_browsing_db.
5 years, 2 months ago (2015-10-22 22:36:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420143002/1
5 years, 2 months ago (2015-10-22 22:36:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 22:38:44 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1f66733b39fdc5499c034497a3747a97b5bcc0db Cr-Commit-Position: refs/heads/master@{#355659}
5 years, 2 months ago (2015-10-22 22:39:36 UTC) #4
vakh (old account. dont use)
Apologies for breaking the build. Other than all the bots passing, is there another way ...
5 years, 2 months ago (2015-10-22 22:55:29 UTC) #5
DaleCurtis
5 years, 2 months ago (2015-10-23 01:09:44 UTC) #6
Message was sent while issue was closed.
The problem is we're missing x64 GN CQ bots right now which would have caught
this.... https://code.google.com/p/chromium/issues/detail?id=486089 tracks this
I think :/

Powered by Google App Engine
This is Rietveld 408576698