chrome/test/data/prerender/prerender_page_pending.html - Issue 142013004: Re-enable prerender RemovingLink browser tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/prerender/prerender_page_pending.html

Issue 142013004: Re-enable prerender RemovingLink browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: New test, and machinery to support said test. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/prerender/prerender_events_common.js ('K') | « chrome/test/data/prerender/prerender_loader_removing_links.html ('k') | chrome/test/data/prerender/prerender_page_removes_pending.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <!--	2 <!--

3 This test checks to make sure that pending prerenders start at page launch,	3 This test checks to make sure that pending prerenders start at page launch,

4 but not earlier.	4 but not earlier.

5 -->	5 -->

6 <link id=thePrerender rel=prerender href="prerender_page.html" />	6 <link id=thePrerender rel=prerender href="prerender_page.html" />

7 <head>	7 <head>

8 <title>Prerender Page</title>	8 <title>Prerender Page</title>

9	9

10 <script src="prerender_events_common.js"></script>	10 <script src="prerender_events_common.js"></script>

11	11

12 <script>	12 <script>

13 var pageWasPrerendered = false;	13 var pageWasPrerendered = false;

14	14

15 function DidPrerenderPass() {	15 function DidPrerenderPass() {

16 pageWasPrerendered = true;	16 pageWasPrerendered = true;

17 return !receivedPrerenderStartEvents[0] && !receivedPrerenderStopEvents[0];	17 return !GetPrerenderEventCount(0, 'webkitprerenderstart');
	mmenke 2014/02/13 16:34:33 optional: I think it may make more sense to check optional: I think it may make more sense to check for event errors here and in DidDisplay pass than in C++, just in case we ever reuse this file (Same goes for the other one) davidben 2014/02/14 01:01:13 Hrm. DidDisplayPass gets called before the pending Show quoted text On 2014/02/13 16:34:33, mmenke wrote: > optional: I think it may make more sense to check for event errors here and in > DidDisplay pass than in C++, just in case we ever reuse this file (Same goes for > the other one) Hrm. DidDisplayPass gets called before the pending prerender is necessarily started though. Actually we currently don't test this page's prerender events at all post-swap, which should be fixed... This is actually an unrelated test, so I'll hold on that for a separate CL.
18 }	18 }

19	19

20 // Make sure DidPrerenderPass() was called first. Otherwise, the page was	20 // Make sure DidPrerenderPass() was called first. Otherwise, the page was

21 // most likely reloaded instead of using the prerendered page.	21 // most likely reloaded instead of using the prerendered page.

22 function DidDisplayPass() {	22 function DidDisplayPass() {

23 return pageWasPrerendered;	23 return pageWasPrerendered;

24 }	24 }

25	25

26 var link = document.getElementById('thePrerender');	26 var link = document.getElementById('thePrerender');

27 AddEventHandlersToLinkElement(link, 0);	27 AddEventHandlersToLinkElement(link, 0);

28 </script>	28 </script>

29	29

30 </head>	30 </head>

31 <body></body>	31 <body></body>

32 </html>	32 </html>

OLD	NEW