Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 14201003: intsafe workaround to separate header (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

intsafe workaround to separate header Allows workaround to work without precompiled headers (as in buildtype=Official) R=cpu@chromium.org BUG=225822 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
A build/intsafe_workaround.h View 1 chunk +27 lines, -0 lines 0 comments Download
M build/precompile.h View 1 chunk +1 line, -18 lines 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
7 years, 8 months ago (2013-04-12 00:11:07 UTC) #1
ChromiumProblem
Patch works for me. Thank you!
7 years, 8 months ago (2013-04-12 13:19:55 UTC) #2
scottmg
cpu, ping
7 years, 8 months ago (2013-04-16 18:05:43 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
7 years, 8 months ago (2013-04-16 21:27:56 UTC) #4
scottmg
7 years, 8 months ago (2013-04-17 01:15:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r194506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698