Make sure StyleResolver sets viewport before initializing HTMLPreloadScanner

Make sure StyleResolver sets viewport before initializing HTMLPreloadScanner

Following https://codereview.chromium.org/1392213002/ this CL makes sure
that the default viewport is set on the document before HTMLPreloadScanner is
initialized, in order to avoid double downloads in all cases.

BUG=531820
Committed: https://crrev.com/e746b156143efdad62f8a76ae5a5c60d3b2302e8
Cr-Commit-Position: refs/heads/master@{#356275}

[Yoav Weiss, 2015-10-22 15:41:31]

yoav@yoav.ws changed reviewers:
+ bokan@chromium.org

[Yoav Weiss, 2015-10-22 15:41:31]

Hey David :)

This continues (and hopefully ends) our double downloading saga.
Can you take a look?

[bokan, 2015-10-22 16:56:46]

Why didn't the browser test you added last time catch this?

Unfortunately, my knowledge of parsing/style is quite limited. Given that you're
an OWNER in that file, you probably know better than I who would be a good
reviewer :) But I see no problem with this.

https://codereview.chromium.org/1420073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp (right):

https://codereview.chromium.org/1420073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp:798: 
Nit: Remove extra space?

[Yoav Weiss, 2015-10-23 07:06:26]

On 2015/10/22 16:56:46, bokan wrote:
> Why didn't the browser test you added last time catch this?

Good question. Not sure, but I'm trying to find out.

> 
> Unfortunately, my knowledge of parsing/style is quite limited. Given that
you're
> an OWNER in that file, you probably know better than I who would be a good
> reviewer :) But I see no problem with this.

I'll loop other reviewers in, thanks!

Also, the test failures seem to indicate that this might not be the way to go...
I'll look into that as well.

> 
>
https://codereview.chromium.org/1420073002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
(right):
> 
>
https://codereview.chromium.org/1420073002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp:798: 
> Nit: Remove extra space?

[Yoav Weiss, 2015-10-23 07:39:07]

yoav@yoav.ws changed reviewers:
+ kouhei@chromium.org

[Yoav Weiss, 2015-10-23 07:39:08]

Kouhei,

Can you take a look?

[kouhei (in TOK), 2015-10-27 03:54:21]

On 2015/10/23 07:39:08, Yoav Weiss wrote:
> Kouhei,
> 
> Can you take a look?

lgtm

[Yoav Weiss, 2015-10-27 04:34:16]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2015-10-27 04:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420073002/40001

[commit-bot: I haz the power, 2015-10-27 04:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 04:44:04]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yoav Weiss, 2015-10-27 04:45:24]

yoav@yoav.ws changed reviewers:
+ jochen@chromium.org

[Yoav Weiss, 2015-10-27 04:45:25]

Jochen - mind taking a look at the tests?

[jochen (gone - plz use gerrit), 2015-10-27 12:14:30]

lgtm

[Yoav Weiss, 2015-10-27 12:15:01]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2015-10-27 12:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420073002/40001

[commit-bot: I haz the power, 2015-10-27 12:19:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-27 12:20:45]

Patchset 3 (id:??) landed as
https://crrev.com/e746b156143efdad62f8a76ae5a5c60d3b2302e8
Cr-Commit-Position: refs/heads/master@{#356275}