Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1420053009: Revert of Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" (patchset #1 id:1 of https://codereview.chromium.org/1410343011/ ) Reason for revert: failing on msaa Original issue's description: > Revert[2] of "stop using drawSprite (at least w/ no filters) as it is going away" > > Fixed assert in test that was calling GrRecordReplaceDraw(). That function now uses > drawBitmap, so updated the test to check for that (instead of drawSprite). > > This reverts commit 21b766347064837e6b78d600755901aad88cd6e0. > > BUG=skia: > TBR= > > Committed: https://skia.googlesource.com/skia/+/7b81994d95f10cda80ddb85af68a2651ff31782f TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/67b8b5e67a427382fed8c5d8b3c70a21ed2492c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M samplecode/SampleAll.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of Revert[2] of "stop using drawSprite (at least w/ no filters) as it ...
5 years, 1 month ago (2015-11-03 19:26:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420053009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420053009/1
5 years, 1 month ago (2015-11-03 19:26:59 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 19:27:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/67b8b5e67a427382fed8c5d8b3c70a21ed2492c6

Powered by Google App Engine
This is Rietveld 408576698