Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/safe_browsing/threat_details_unittest.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Remove '// namespace safe_browsing' for a small fwd decl block. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/threat_details_unittest.cc
diff --git a/chrome/browser/safe_browsing/threat_details_unittest.cc b/chrome/browser/safe_browsing/threat_details_unittest.cc
index a6b3cc9f205f8a72452f6a8718e18d65dbc12899..fa77f4a122ba7de366fa33f7bc6c47c1bbd7a208 100644
--- a/chrome/browser/safe_browsing/threat_details_unittest.cc
+++ b/chrome/browser/safe_browsing/threat_details_unittest.cc
@@ -33,6 +33,13 @@
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
+using content::BrowserThread;
+using content::WebContents;
+
+namespace safe_browsing {
+
+namespace {
+
// Mixture of HTTP and HTTPS. No special treatment for HTTPS.
static const char* kOriginalLandingURL =
"http://www.originallandingpage.com/with/path";
@@ -59,9 +66,6 @@ static const char* kLandingData =
using content::BrowserThread;
using content::WebContents;
-using safe_browsing::ClientSafeBrowsingReportRequest;
-
-namespace {
void WriteHeaders(disk_cache::Entry* entry, const std::string& headers) {
net::HttpResponseInfo responseinfo;
@@ -175,7 +179,7 @@ class MockSafeBrowsingUIManager : public SafeBrowsingUIManager {
DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingUIManager);
};
-} // namespace.
+} // namespace
class ThreatDetailsTest : public ChromeRenderViewHostTestHarness {
public:
@@ -575,10 +579,10 @@ TEST_F(ThreatDetailsTest, HTTPCache) {
expected.add_resources();
pb_resource->set_id(0);
pb_resource->set_url(kLandingURL);
- safe_browsing::ClientSafeBrowsingReportRequest::HTTPResponse* pb_response =
+ ClientSafeBrowsingReportRequest::HTTPResponse* pb_response =
pb_resource->mutable_response();
pb_response->mutable_firstline()->set_code(200);
- safe_browsing::ClientSafeBrowsingReportRequest::HTTPHeader* pb_header =
+ ClientSafeBrowsingReportRequest::HTTPHeader* pb_header =
pb_response->add_headers();
pb_header->set_name("Content-Type");
pb_header->set_value("text/html");
@@ -718,3 +722,5 @@ TEST_F(ThreatDetailsTest, HistoryServiceUrls) {
VerifyResults(actual, expected);
}
+
+} // namespace safe_browsing
« no previous file with comments | « chrome/browser/safe_browsing/threat_details_history.cc ('k') | chrome/browser/safe_browsing/two_phase_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698