Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2029)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Remove '// namespace safe_browsing' for a small fwd decl block. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 0f9ef893152587a4522fea7464ecdf214c4c22d2..00b13e12d17bfacbc3bf62b0c2953fe265b39980 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -30,14 +30,6 @@
class PrefChangeRegistrar;
class PrefService;
class Profile;
-struct SafeBrowsingProtocolConfig;
-class SafeBrowsingDatabaseManager;
-class SafeBrowsingPingManager;
-class SafeBrowsingProtocolManager;
-class SafeBrowsingProtocolManagerDelegate;
-class SafeBrowsingServiceFactory;
-class SafeBrowsingUIManager;
-class SafeBrowsingURLRequestContextGetter;
class TrackedPreferenceValidationDelegate;
namespace base {
@@ -57,13 +49,20 @@ class URLRequestContextGetter;
namespace safe_browsing {
class ClientSideDetectionService;
class DownloadProtectionService;
+struct SafeBrowsingProtocolConfig;
+class SafeBrowsingDatabaseManager;
+class SafeBrowsingPingManager;
+class SafeBrowsingProtocolManager;
+class SafeBrowsingProtocolManagerDelegate;
+class SafeBrowsingServiceFactory;
+class SafeBrowsingUIManager;
+class SafeBrowsingURLRequestContextGetter;
#if defined(FULL_SAFE_BROWSING)
class IncidentReportingService;
class OffDomainInclusionDetector;
class ResourceRequestDetector;
#endif
-} // namespace safe_browsing
// Construction needs to happen on the main thread.
// The SafeBrowsingService owns both the UI and Database managers which do
@@ -115,16 +114,14 @@ class SafeBrowsingService
return enabled_by_prefs_;
}
- safe_browsing::ClientSideDetectionService*
- safe_browsing_detection_service() const {
+ ClientSideDetectionService* safe_browsing_detection_service() const {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
return csd_service_.get();
}
// The DownloadProtectionService is not valid after the SafeBrowsingService
// is destroyed.
- safe_browsing::DownloadProtectionService*
- download_protection_service() const {
+ DownloadProtectionService* download_protection_service() const {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
return download_service_.get();
}
@@ -149,8 +146,7 @@ class SafeBrowsingService
// Registers |callback| to be run after some delay following process launch.
// |callback| will be dropped if the service is not applicable for the
// process.
- void RegisterDelayedAnalysisCallback(
- const safe_browsing::DelayedAnalysisCallback& callback);
+ void RegisterDelayedAnalysisCallback(const DelayedAnalysisCallback& callback);
#endif
// Adds |download_manager| to the set monitored by safe browsing.
@@ -180,8 +176,7 @@ class SafeBrowsingService
virtual SafeBrowsingUIManager* CreateUIManager();
#if defined(FULL_SAFE_BROWSING)
- virtual safe_browsing::IncidentReportingService*
- CreateIncidentReportingService();
+ virtual IncidentReportingService* CreateIncidentReportingService();
#endif
// Registers all the delayed analysis with the incident reporting service.
@@ -287,15 +282,15 @@ class SafeBrowsingService
// The ClientSideDetectionService is managed by the SafeBrowsingService,
// since its running state and lifecycle depends on SafeBrowsingService's.
// Accessed on UI thread.
- scoped_ptr<safe_browsing::ClientSideDetectionService> csd_service_;
+ scoped_ptr<ClientSideDetectionService> csd_service_;
// The DownloadProtectionService is managed by the SafeBrowsingService,
// since its running state and lifecycle depends on SafeBrowsingService's.
// Accessed on UI thread.
- scoped_ptr<safe_browsing::DownloadProtectionService> download_service_;
+ scoped_ptr<DownloadProtectionService> download_service_;
#if defined(FULL_SAFE_BROWSING)
- scoped_ptr<safe_browsing::IncidentReportingService> incident_service_;
+ scoped_ptr<IncidentReportingService> incident_service_;
#endif
// The UI manager handles showing interstitials. Accessed on both UI and IO
@@ -307,10 +302,9 @@ class SafeBrowsingService
scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;
#if defined(FULL_SAFE_BROWSING)
- scoped_ptr<safe_browsing::OffDomainInclusionDetector>
- off_domain_inclusion_detector_;
+ scoped_ptr<OffDomainInclusionDetector> off_domain_inclusion_detector_;
- scoped_ptr<safe_browsing::ResourceRequestDetector> resource_request_detector_;
+ scoped_ptr<ResourceRequestDetector> resource_request_detector_;
#endif
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
@@ -326,4 +320,6 @@ class SafeBrowsingServiceFactory {
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingServiceFactory);
};
+} // namespace safe_browsing
+
#endif // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698