Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Remove '// namespace safe_browsing' for a small fwd decl block. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
index 7d4aa23952e726dff0dd65326a1445ad201e916c..b08ed6160d0f9d2ffcf5bead7c31ce15c35343ae 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
@@ -52,6 +52,8 @@ using content::InterstitialPage;
using content::NavigationController;
using content::WebContents;
+namespace safe_browsing {
+
namespace {
const char kEmptyPage[] = "empty.html";
@@ -92,7 +94,7 @@ class FakeSafeBrowsingDatabaseManager : public TestSafeBrowsingDatabaseManager {
std::vector<GURL>(1, gurl),
std::vector<SBFullHash>(),
client,
- safe_browsing::MALWARE,
+ MALWARE,
expected_threats);
sb_check.url_results[0] = badurls[gurl.spec()];
sb_check.OnSafeBrowsingResult();
@@ -745,7 +747,7 @@ IN_PROC_BROWSER_TEST_P(SafeBrowsingBlockingPageBrowserTest,
if (expect_threat_details) {
threat_report_sent_runner->Run();
std::string serialized = GetReportSent();
- safe_browsing::ClientSafeBrowsingReportRequest report;
+ ClientSafeBrowsingReportRequest report;
ASSERT_TRUE(report.ParseFromString(serialized));
// Verify the report is complete.
EXPECT_TRUE(report.complete());
@@ -1024,3 +1026,5 @@ INSTANTIATE_TEST_CASE_P(SafeBrowsingBlockingPageIDNTestWithThreatType,
testing::Values(SB_THREAT_TYPE_URL_MALWARE,
SB_THREAT_TYPE_URL_PHISHING,
SB_THREAT_TYPE_URL_UNWANTED));
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698