Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8655)

Unified Diff: chrome/browser/safe_browsing/local_database_manager_unittest.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Remove '// namespace safe_browsing' for a small fwd decl block. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/local_database_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/local_database_manager_unittest.cc b/chrome/browser/safe_browsing/local_database_manager_unittest.cc
index b4bbc3056fe7bbef884f5caba63e3513bb7d0253..8b58e604e3e78f891c3ac8f58b921c55ccb79e7f 100644
--- a/chrome/browser/safe_browsing/local_database_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/local_database_manager_unittest.cc
@@ -18,6 +18,8 @@
using content::TestBrowserThreadBundle;
+namespace safe_browsing {
+
namespace {
class TestClient : public SafeBrowsingDatabaseManager::Client {
@@ -40,7 +42,7 @@ class TestClient : public SafeBrowsingDatabaseManager::Client {
class SafeBrowsingDatabaseManagerTest : public PlatformTest {
public:
- bool RunSBHashTest(const safe_browsing::ListType list_type,
+ bool RunSBHashTest(const ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::string& result_list);
@@ -49,7 +51,7 @@ class SafeBrowsingDatabaseManagerTest : public PlatformTest {
};
bool SafeBrowsingDatabaseManagerTest::RunSBHashTest(
- const safe_browsing::ListType list_type,
+ const ListType list_type,
const std::vector<SBThreatType>& expected_threats,
const std::string& result_list) {
scoped_refptr<SafeBrowsingService> sb_service_(
@@ -60,17 +62,12 @@ bool SafeBrowsingDatabaseManagerTest::RunSBHashTest(
LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck* check =
new LocalSafeBrowsingDatabaseManager::SafeBrowsingCheck(
- std::vector<GURL>(),
- std::vector<SBFullHash>(1, same_full_hash),
- NULL,
- list_type,
- expected_threats);
+ std::vector<GURL>(), std::vector<SBFullHash>(1, same_full_hash), NULL,
+ list_type, expected_threats);
db_manager_->checks_.insert(check);
- const SBFullHashResult full_hash_result = {
- same_full_hash,
- safe_browsing::GetListId(result_list)
- };
+ const SBFullHashResult full_hash_result = {same_full_hash,
+ GetListId(result_list)};
std::vector<SBFullHashResult> fake_results(1, full_hash_result);
bool result = db_manager_->HandleOneCheck(check, fake_results);
@@ -82,23 +79,15 @@ bool SafeBrowsingDatabaseManagerTest::RunSBHashTest(
TEST_F(SafeBrowsingDatabaseManagerTest, CheckCorrespondsListType) {
std::vector<SBThreatType> malware_threat(1,
SB_THREAT_TYPE_BINARY_MALWARE_URL);
- EXPECT_FALSE(RunSBHashTest(safe_browsing::BINURL,
- malware_threat,
- safe_browsing::kMalwareList));
- EXPECT_TRUE(RunSBHashTest(safe_browsing::BINURL,
- malware_threat,
- safe_browsing::kBinUrlList));
+ EXPECT_FALSE(RunSBHashTest(BINURL, malware_threat, kMalwareList));
+ EXPECT_TRUE(RunSBHashTest(BINURL, malware_threat, kBinUrlList));
// Check for multiple threats
std::vector<SBThreatType> multiple_threats;
multiple_threats.push_back(SB_THREAT_TYPE_URL_MALWARE);
multiple_threats.push_back(SB_THREAT_TYPE_URL_PHISHING);
- EXPECT_FALSE(RunSBHashTest(safe_browsing::MALWARE,
- multiple_threats,
- safe_browsing::kBinUrlList));
- EXPECT_TRUE(RunSBHashTest(safe_browsing::MALWARE,
- multiple_threats,
- safe_browsing::kMalwareList));
+ EXPECT_FALSE(RunSBHashTest(MALWARE, multiple_threats, kBinUrlList));
+ EXPECT_TRUE(RunSBHashTest(MALWARE, multiple_threats, kMalwareList));
}
TEST_F(SafeBrowsingDatabaseManagerTest, GetUrlSeverestThreatType) {
@@ -111,35 +100,31 @@ TEST_F(SafeBrowsingDatabaseManagerTest, GetUrlSeverestThreatType) {
"http://www.unwantedandmalware.com/page.html");
const GURL kSafeUrl("http://www.safe.com/page.html");
- const SBFullHash kMalwareHostHash =
- safe_browsing::SBFullHashForString("malware.com/");
- const SBFullHash kPhishingHostHash =
- safe_browsing::SBFullHashForString("phishing.com/");
- const SBFullHash kUnwantedHostHash =
- safe_browsing::SBFullHashForString("unwanted.com/");
+ const SBFullHash kMalwareHostHash = SBFullHashForString("malware.com/");
+ const SBFullHash kPhishingHostHash = SBFullHashForString("phishing.com/");
+ const SBFullHash kUnwantedHostHash = SBFullHashForString("unwanted.com/");
const SBFullHash kUnwantedAndMalwareHostHash =
- safe_browsing::SBFullHashForString("unwantedandmalware.com/");
- const SBFullHash kSafeHostHash =
- safe_browsing::SBFullHashForString("www.safe.com/");
+ SBFullHashForString("unwantedandmalware.com/");
+ const SBFullHash kSafeHostHash = SBFullHashForString("www.safe.com/");
{
SBFullHashResult full_hash;
full_hash.hash = kMalwareHostHash;
- full_hash.list_id = static_cast<int>(safe_browsing::MALWARE);
+ full_hash.list_id = static_cast<int>(MALWARE);
full_hashes.push_back(full_hash);
}
{
SBFullHashResult full_hash;
full_hash.hash = kPhishingHostHash;
- full_hash.list_id = static_cast<int>(safe_browsing::PHISH);
+ full_hash.list_id = static_cast<int>(PHISH);
full_hashes.push_back(full_hash);
}
{
SBFullHashResult full_hash;
full_hash.hash = kUnwantedHostHash;
- full_hash.list_id = static_cast<int>(safe_browsing::UNWANTEDURL);
+ full_hash.list_id = static_cast<int>(UNWANTEDURL);
full_hashes.push_back(full_hash);
}
@@ -148,12 +133,12 @@ TEST_F(SafeBrowsingDatabaseManagerTest, GetUrlSeverestThreatType) {
// kUnwantedAndMalwareHostHash.
SBFullHashResult full_hash_malware;
full_hash_malware.hash = kUnwantedAndMalwareHostHash;
- full_hash_malware.list_id = static_cast<int>(safe_browsing::MALWARE);
+ full_hash_malware.list_id = static_cast<int>(MALWARE);
full_hashes.push_back(full_hash_malware);
SBFullHashResult full_hash_unwanted;
full_hash_unwanted.hash = kUnwantedAndMalwareHostHash;
- full_hash_unwanted.list_id = static_cast<int>(safe_browsing::UNWANTEDURL);
+ full_hash_unwanted.list_id = static_cast<int>(UNWANTEDURL);
full_hashes.push_back(full_hash_unwanted);
}
@@ -232,3 +217,5 @@ TEST_F(SafeBrowsingDatabaseManagerTest, ServiceStopWithPendingChecks) {
content::RunAllBlockingPoolTasksUntilIdle();
base::RunLoop().RunUntilIdle();
}
+
+} // namespace safe_browsing
« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/local_safebrowsing_test_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698