Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3084)

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Merging the latest changes from trunk. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/protocol_parser.cc
diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc
index 135e76f661cec927852e836b4971c9b07906ca2d..5c1c1354a77ca09ccacc451efe7b0c063743ad5c 100644
--- a/chrome/browser/safe_browsing/protocol_parser.cc
+++ b/chrome/browser/safe_browsing/protocol_parser.cc
@@ -19,7 +19,7 @@
#include "chrome/browser/safe_browsing/protocol_parser.h"
#include "chrome/browser/safe_browsing/safe_browsing_util.h"
-namespace {
+namespace safe_browsing {
// Helper class for scanning a buffer.
Nathan Parker 2015/11/05 22:00:52 If this is used only in this file, you could put i
vakh (old account. dont use) 2015/11/07 01:22:56 Done.
class BufferReader {
@@ -155,10 +155,6 @@ bool ParseGetHashMetadata(size_t hash_count,
return true;
}
-} // namespace
-
-namespace safe_browsing {
-
// BODY = CACHELIFETIME LF HASHENTRY* EOF
// CACHELIFETIME = DIGIT+
// HASHENTRY = LISTNAME ":" HASHSIZE ":" NUMRESPONSES [":m"] LF
@@ -199,7 +195,7 @@ bool ParseGetHash(const char* chunk_data,
return false;
SBFullHashResult full_hash;
- full_hash.list_id = safe_browsing::GetListId(cmd_parts[0]);
+ full_hash.list_id = GetListId(cmd_parts[0]);
size_t hash_len;
if (!base::StringToSizeT(cmd_parts[1], &hash_len))

Powered by Google App Engine
This is Rietveld 408576698