Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: chrome/browser/safe_browsing/threat_details_cache.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Bring back anon namespace. Remove safe_browsing:: wherever not needed. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/threat_details_cache.cc
diff --git a/chrome/browser/safe_browsing/threat_details_cache.cc b/chrome/browser/safe_browsing/threat_details_cache.cc
index 05a78e01b6b52e78d06ad48a8d6b09486cb371ce..c09f1c39bb095f47332a96da1776dbfad791deba 100644
--- a/chrome/browser/safe_browsing/threat_details_cache.cc
+++ b/chrome/browser/safe_browsing/threat_details_cache.cc
@@ -23,7 +23,10 @@
#include "net/url_request/url_request_status.h"
using content::BrowserThread;
-using safe_browsing::ClientMalwareReportRequest;
+
+namespace safe_browsing {
+
+class ClientMalwareReportRequest;
Nathan Parker 2015/11/11 21:23:36 Shouldn't need this pre-decl, since it must be in
vakh (old account. dont use) 2015/11/11 23:22:46 Done.
// Only send small files for now, a better strategy would use the size
// of the whole report and the user's bandwidth.
@@ -34,7 +37,7 @@ ThreatDetailsCacheCollector::ThreatDetailsCacheCollector()
void ThreatDetailsCacheCollector::StartCacheCollection(
net::URLRequestContextGetter* request_context_getter,
- safe_browsing::ResourceMap* resources,
+ ResourceMap* resources,
bool* result,
const base::Closure& callback) {
// Start the data collection from the HTTP cache. We use a URLFetcher
@@ -89,7 +92,7 @@ void ThreatDetailsCacheCollector::OpenEntry() {
ClientMalwareReportRequest::Resource* ThreatDetailsCacheCollector::GetResource(
const GURL& url) {
- safe_browsing::ResourceMap::iterator it = resources_->find(url.spec());
+ ResourceMap::iterator it = resources_->find(url.spec());
if (it != resources_->end()) {
return it->second.get();
}
@@ -201,3 +204,5 @@ void ThreatDetailsCacheCollector::AllDone(bool success) {
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
callback_.Reset();
}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698