Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11055)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.h

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Bring back anon namespace. Remove safe_browsing:: wherever not needed. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.h
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.h b/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
index 8f2e4ea89788d0aa3e55c0439816a533b39582f5..e8d2d1245083bca3a9e6346f60657af3d07fe302 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
@@ -18,6 +18,9 @@
#include "content/public/common/resource_type.h"
#include "net/log/net_log.h"
+using safe_browsing::SafeBrowsingDatabaseManager;
Nathan Parker 2015/11/11 21:23:36 shouldn't use "using" in .h's.
vakh (old account. dont use) 2015/11/11 23:22:46 Done.
+using safe_browsing::SafeBrowsingUIManager;
+
class ResourceDispatcherHost;
namespace net {
@@ -70,7 +73,7 @@ class SafeBrowsingResourceThrottle
static SafeBrowsingResourceThrottle* MaybeCreate(
net::URLRequest* request,
content::ResourceType resource_type,
- SafeBrowsingService* sb_service);
+ safe_browsing::SafeBrowsingService* sb_service);
// content::ResourceThrottle implementation (called on IO thread):
void WillStartRequest(bool* defer) override;
@@ -82,13 +85,13 @@ class SafeBrowsingResourceThrottle
// SafeBrowsingDabaseManager::Client implementation (called on IO thread):
void OnCheckBrowseUrlResult(const GURL& url,
- SBThreatType result,
+ safe_browsing::SBThreatType result,
const std::string& metadata) override;
protected:
SafeBrowsingResourceThrottle(const net::URLRequest* request,
content::ResourceType resource_type,
- SafeBrowsingService* sb_service);
+ safe_browsing::SafeBrowsingService* sb_service);
private:
// Describes what phase of the check a throttle is in.
@@ -153,7 +156,7 @@ class SafeBrowsingResourceThrottle
// The result of the most recent safe browsing check. Only valid to read this
// when state_ != STATE_CHECKING_URL.
- SBThreatType threat_type_;
+ safe_browsing::SBThreatType threat_type_;
// The time when we started deferring the request.
base::TimeTicks defer_start_time_;

Powered by Google App Engine
This is Rietveld 408576698