Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/safe_browsing/threat_details_unittest.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Other minor fixes incl. using "using safe_browsing::ClassName" instead of safe_browsing::ClassName everywhere. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/threat_details_unittest.cc
diff --git a/chrome/browser/safe_browsing/threat_details_unittest.cc b/chrome/browser/safe_browsing/threat_details_unittest.cc
index f537c5c9948b2c84924703605f9f9b1e1a8ee99d..00305cfecc26548b744e1398f50a2ab38235cde6 100644
--- a/chrome/browser/safe_browsing/threat_details_unittest.cc
+++ b/chrome/browser/safe_browsing/threat_details_unittest.cc
@@ -59,9 +59,8 @@ static const char* kLandingData =
using content::BrowserThread;
using content::WebContents;
-using safe_browsing::ClientMalwareReportRequest;
-namespace {
+namespace safe_browsing {
void WriteHeaders(disk_cache::Entry* entry, const std::string& headers) {
net::HttpResponseInfo responseinfo;
@@ -175,8 +174,6 @@ class MockSafeBrowsingUIManager : public SafeBrowsingUIManager {
DISALLOW_COPY_AND_ASSIGN(MockSafeBrowsingUIManager);
};
mattm 2015/11/11 01:10:16 Keep the anon namespace inside the new namespace.
vakh (old account. dont use) 2015/11/11 18:59:53 Done.
-} // namespace.
-
class ThreatDetailsTest : public ChromeRenderViewHostTestHarness {
public:
typedef SafeBrowsingUIManager::UnsafeResource UnsafeResource;
@@ -561,10 +558,10 @@ TEST_F(ThreatDetailsTest, HTTPCache) {
ClientMalwareReportRequest::Resource* pb_resource = expected.add_resources();
pb_resource->set_id(0);
pb_resource->set_url(kLandingURL);
- safe_browsing::ClientMalwareReportRequest::HTTPResponse* pb_response =
+ ClientMalwareReportRequest::HTTPResponse* pb_response =
pb_resource->mutable_response();
pb_response->mutable_firstline()->set_code(200);
- safe_browsing::ClientMalwareReportRequest::HTTPHeader* pb_header =
+ ClientMalwareReportRequest::HTTPHeader* pb_header =
pb_response->add_headers();
pb_header->set_name("Content-Type");
pb_header->set_value("text/html");
@@ -697,3 +694,5 @@ TEST_F(ThreatDetailsTest, HistoryServiceUrls) {
VerifyResults(actual, expected);
}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698