Chromium Code Reviews| Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc |
| diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc |
| index 222cb7b9d30d3f2220a20e1a3f821c0679e748b8..4c132debdbca32d32cfa250a104e4de69d874f7c 100644 |
| --- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc |
| +++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc |
| @@ -70,7 +70,7 @@ using ::testing::_; |
| using ::testing::Mock; |
| using ::testing::StrictMock; |
| -namespace { |
| +namespace safe_browsing { |
| void InvokeFullHashCallback( |
| SafeBrowsingProtocolManager::FullHashCallback callback, |
| @@ -411,8 +411,6 @@ class ServiceEnabledHelper : public base::ThreadTestHelper { |
| const bool expected_enabled_; |
| }; |
| -} // namespace |
|
mattm
2015/11/11 01:10:16
Keep the anon namespace inside the new namespace.
vakh (old account. dont use)
2015/11/11 18:59:53
Done.
|
| - |
| // Tests the safe browsing blocking page in a browser. |
| class SafeBrowsingServiceTest : public InProcessBrowserTest { |
| public: |
| @@ -527,8 +525,8 @@ class SafeBrowsingServiceTest : public InProcessBrowserTest { |
| void CreateCSDService() { |
| #if defined(SAFE_BROWSING_CSD) |
| - safe_browsing::ClientSideDetectionService* csd_service = |
| - safe_browsing::ClientSideDetectionService::Create(NULL); |
| + ClientSideDetectionService* csd_service = |
| + ClientSideDetectionService::Create(NULL); |
| SafeBrowsingService* sb_service = |
| g_browser_process->safe_browsing_service(); |
| @@ -603,17 +601,17 @@ class SafeBrowsingServiceMetadataTest |
| SBFullHashResult* full_hash) { |
| GenUrlFullhashResult(url, safe_browsing::MALWARE, full_hash); |
| - safe_browsing::MalwarePatternType proto; |
| + MalwarePatternType proto; |
| switch (GetParam()) { |
| case METADATA_NONE: |
| full_hash->metadata = std::string(); |
| break; |
| case METADATA_LANDING: |
| - proto.set_pattern_type(safe_browsing::MalwarePatternType::LANDING); |
| + proto.set_pattern_type(MalwarePatternType::LANDING); |
| full_hash->metadata = proto.SerializeAsString(); |
| break; |
| case METADATA_DISTRIBUTION: |
| - proto.set_pattern_type(safe_browsing::MalwarePatternType::DISTRIBUTION); |
| + proto.set_pattern_type(MalwarePatternType::DISTRIBUTION); |
| full_hash->metadata = proto.SerializeAsString(); |
| break; |
| } |
| @@ -1057,7 +1055,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, |
| IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceTest, StartAndStop) { |
| CreateCSDService(); |
| SafeBrowsingService* sb_service = g_browser_process->safe_browsing_service(); |
| - safe_browsing::ClientSideDetectionService* csd_service = |
| + ClientSideDetectionService* csd_service = |
| sb_service->safe_browsing_detection_service(); |
| PrefService* pref_service = browser()->profile()->GetPrefs(); |
| @@ -1156,7 +1154,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServiceShutdownTest, |
| DontStartAfterShutdown) { |
| CreateCSDService(); |
| SafeBrowsingService* sb_service = g_browser_process->safe_browsing_service(); |
| - safe_browsing::ClientSideDetectionService* csd_service = |
| + ClientSideDetectionService* csd_service = |
| sb_service->safe_browsing_detection_service(); |
| PrefService* pref_service = browser()->profile()->GetPrefs(); |
| @@ -1360,3 +1358,5 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingDatabaseManagerCookieTest, |
| base::Bind(&SafeBrowsingDatabaseManagerCookieTest::ForceUpdate, this)); |
| observer.Wait(); |
| } |
| + |
| +} // namespace safe_browsing |