chrome/browser/safe_browsing/protocol_parser.cc - Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move

Patch Set: Other minor fixes incl. using "using safe_browsing::ClassName" instead of safe_browsing::ClassName everywhere. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/local_database_manager_unittest.cc ('K') | « chrome/browser/safe_browsing/protocol_manager_unittest.cc ('k') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('j') | chrome/browser/safe_browsing/protocol_parser_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_parser.cc

diff --git a/chrome/browser/safe_browsing/protocol_parser.cc b/chrome/browser/safe_browsing/protocol_parser.cc

index 135e76f661cec927852e836b4971c9b07906ca2d..1ad27c2d66a20cdc26d53c73b462250833f45248 100644

--- a/chrome/browser/safe_browsing/protocol_parser.cc

+++ b/chrome/browser/safe_browsing/protocol_parser.cc

@@ -131,9 +131,10 @@ class BufferReader {

DISALLOW_COPY_AND_ASSIGN(BufferReader);

};

-bool ParseGetHashMetadata(size_t hash_count,

- BufferReader* reader,

- std::vector<SBFullHashResult>* full_hashes) {

+bool ParseGetHashMetadata(

+ size_t hash_count,

+ BufferReader* reader,

+ std::vector<safe_browsing::SBFullHashResult>* full_hashes) {

for (size_t i = 0; i < hash_count; ++i) {

base::StringPiece line;

if (!reader->GetLine(&line))

@@ -199,7 +200,7 @@ bool ParseGetHash(const char* chunk_data,

return false;

SBFullHashResult full_hash;

- full_hash.list_id = safe_browsing::GetListId(cmd_parts[0]);

+ full_hash.list_id = GetListId(cmd_parts[0]);

size_t hash_len;

if (!base::StringToSizeT(cmd_parts[1], &hash_len))