Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_store_unittest.cc

Issue 1420053005: Move code in components/safe_browsing_db and chrome/browser/s_b/ under the safe_browsing namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@02_components_move
Patch Set: Remove '// namespace safe_browsing' for a small fwd decl block. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/safe_browsing_store.h" 5 #include "chrome/browser/safe_browsing/safe_browsing_store.h"
6 #include "components/safe_browsing_db/util.h" 6 #include "components/safe_browsing_db/util.h"
7 7
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace safe_browsing {
11
10 namespace { 12 namespace {
11 13
12 const SBFullHash kHash1 = safe_browsing::SBFullHashForString("one"); 14 const SBFullHash kHash1 = SBFullHashForString("one");
13 const SBFullHash kHash2 = safe_browsing::SBFullHashForString("two"); 15 const SBFullHash kHash2 = SBFullHashForString("two");
14 const SBFullHash kHash3 = safe_browsing::SBFullHashForString("three"); 16 const SBFullHash kHash3 = SBFullHashForString("three");
15 const SBFullHash kHash4 = safe_browsing::SBFullHashForString("four"); 17 const SBFullHash kHash4 = SBFullHashForString("four");
16 const SBFullHash kHash5 = safe_browsing::SBFullHashForString("five"); 18 const SBFullHash kHash5 = SBFullHashForString("five");
17 const SBFullHash kHash6 = safe_browsing::SBFullHashForString("six"); 19 const SBFullHash kHash6 = SBFullHashForString("six");
18 const SBFullHash kHash7 = safe_browsing::SBFullHashForString("seven"); 20 const SBFullHash kHash7 = SBFullHashForString("seven");
19 21
20 const int kAddChunk1 = 1; // Use different chunk numbers just in case. 22 const int kAddChunk1 = 1; // Use different chunk numbers just in case.
21 const int kSubChunk1 = 2; 23 const int kSubChunk1 = 2;
22 const int kAddChunk2 = 3; 24 const int kAddChunk2 = 3;
23 const int kSubChunk2 = 4; 25 const int kSubChunk2 = 4;
24 const int kAddChunk3 = 5; 26 const int kAddChunk3 = 5;
25 const int kSubChunk3 = 6; 27 const int kSubChunk3 = 6;
26 const int kAddChunk4 = 7; 28 const int kAddChunk4 = 7;
27 const int kSubChunk4 = 8; 29 const int kSubChunk4 = 8;
28 const int kAddChunk5 = 9; 30 const int kAddChunk5 = 9;
(...skipping 18 matching lines...) Expand all
47 SBAddPrefixLess<SBSubPrefix,SBSubPrefix>); 49 SBAddPrefixLess<SBSubPrefix,SBSubPrefix>);
48 std::sort(add_full_hashes->begin(), add_full_hashes->end(), 50 std::sort(add_full_hashes->begin(), add_full_hashes->end(),
49 SBAddPrefixHashLess<SBAddFullHash,SBAddFullHash>); 51 SBAddPrefixHashLess<SBAddFullHash,SBAddFullHash>);
50 std::sort(sub_full_hashes->begin(), sub_full_hashes->end(), 52 std::sort(sub_full_hashes->begin(), sub_full_hashes->end(),
51 SBAddPrefixHashLess<SBSubFullHash,SBSubFullHash>); 53 SBAddPrefixHashLess<SBSubFullHash,SBSubFullHash>);
52 54
53 SBProcessSubs(add_prefixes, sub_prefixes, add_full_hashes, sub_full_hashes, 55 SBProcessSubs(add_prefixes, sub_prefixes, add_full_hashes, sub_full_hashes,
54 add_chunks_deleted, sub_chunks_deleted); 56 add_chunks_deleted, sub_chunks_deleted);
55 } 57 }
56 58
59 } // namespace
60
57 TEST(SafeBrowsingStoreTest, SBAddPrefixLess) { 61 TEST(SafeBrowsingStoreTest, SBAddPrefixLess) {
58 // prefix dominates. 62 // prefix dominates.
59 EXPECT_TRUE(SBAddPrefixLess(SBAddPrefix(11, 1), SBAddPrefix(10, 2))); 63 EXPECT_TRUE(SBAddPrefixLess(SBAddPrefix(11, 1), SBAddPrefix(10, 2)));
60 EXPECT_FALSE(SBAddPrefixLess(SBAddPrefix(10, 2), SBAddPrefix(11, 1))); 64 EXPECT_FALSE(SBAddPrefixLess(SBAddPrefix(10, 2), SBAddPrefix(11, 1)));
61 65
62 // After prefix, chunk_id. 66 // After prefix, chunk_id.
63 EXPECT_TRUE(SBAddPrefixLess(SBAddPrefix(10, 1), SBAddPrefix(11, 1))); 67 EXPECT_TRUE(SBAddPrefixLess(SBAddPrefix(10, 1), SBAddPrefix(11, 1)));
64 EXPECT_FALSE(SBAddPrefixLess(SBAddPrefix(11, 1), SBAddPrefix(10, 1))); 68 EXPECT_FALSE(SBAddPrefixLess(SBAddPrefix(11, 1), SBAddPrefix(10, 1)));
65 69
66 // Equal is not less-than. 70 // Equal is not less-than.
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 const base::hash_set<int32> no_deletions; 215 const base::hash_set<int32> no_deletions;
212 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes, 216 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes,
213 no_deletions, no_deletions); 217 no_deletions, no_deletions);
214 218
215 ASSERT_EQ(1U, add_prefixes.size()); 219 ASSERT_EQ(1U, add_prefixes.size());
216 EXPECT_EQ(kAddChunk7, add_prefixes[0].chunk_id); 220 EXPECT_EQ(kAddChunk7, add_prefixes[0].chunk_id);
217 EXPECT_EQ(kHash2.prefix, add_prefixes[0].prefix); 221 EXPECT_EQ(kHash2.prefix, add_prefixes[0].prefix);
218 222
219 ASSERT_EQ(2U, add_hashes.size()); 223 ASSERT_EQ(2U, add_hashes.size());
220 EXPECT_EQ(kAddChunk5, add_hashes[0].chunk_id); 224 EXPECT_EQ(kAddChunk5, add_hashes[0].chunk_id);
221 EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash4, add_hashes[0].full_hash)); 225 EXPECT_TRUE(SBFullHashEqual(kHash4, add_hashes[0].full_hash));
222 EXPECT_EQ(kAddChunk6, add_hashes[1].chunk_id); 226 EXPECT_EQ(kAddChunk6, add_hashes[1].chunk_id);
223 EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash6, add_hashes[1].full_hash)); 227 EXPECT_TRUE(SBFullHashEqual(kHash6, add_hashes[1].full_hash));
224 228
225 ASSERT_EQ(1U, sub_prefixes.size()); 229 ASSERT_EQ(1U, sub_prefixes.size());
226 EXPECT_EQ(kSubChunk4, sub_prefixes[0].chunk_id); 230 EXPECT_EQ(kSubChunk4, sub_prefixes[0].chunk_id);
227 EXPECT_EQ(kAddChunk4, sub_prefixes[0].add_chunk_id); 231 EXPECT_EQ(kAddChunk4, sub_prefixes[0].add_chunk_id);
228 EXPECT_EQ(kHash3.prefix, sub_prefixes[0].add_prefix); 232 EXPECT_EQ(kHash3.prefix, sub_prefixes[0].add_prefix);
229 233
230 ASSERT_EQ(1U, sub_hashes.size()); 234 ASSERT_EQ(1U, sub_hashes.size());
231 EXPECT_EQ(kSubChunk3, sub_hashes[0].chunk_id); 235 EXPECT_EQ(kSubChunk3, sub_hashes[0].chunk_id);
232 EXPECT_EQ(kAddChunk3, sub_hashes[0].add_chunk_id); 236 EXPECT_EQ(kAddChunk3, sub_hashes[0].add_chunk_id);
233 EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash7, sub_hashes[0].full_hash)); 237 EXPECT_TRUE(SBFullHashEqual(kHash7, sub_hashes[0].full_hash));
234 } 238 }
235 239
236 // Test chunk deletions, and ordering of deletions WRT subs knocking 240 // Test chunk deletions, and ordering of deletions WRT subs knocking
237 // out adds. 241 // out adds.
238 TEST(SafeBrowsingStoreTest, SBProcessSubsDeleteChunk) { 242 TEST(SafeBrowsingStoreTest, SBProcessSubsDeleteChunk) {
239 // A full hash which shares prefix with another. 243 // A full hash which shares prefix with another.
240 const SBFullHash kHash1mod = ModifyHashAfterPrefix(kHash1, 1); 244 const SBFullHash kHash1mod = ModifyHashAfterPrefix(kHash1, 1);
241 245
242 SBAddPrefixes add_prefixes; 246 SBAddPrefixes add_prefixes;
243 std::vector<SBAddFullHash> add_hashes; 247 std::vector<SBAddFullHash> add_hashes;
(...skipping 24 matching lines...) Expand all
268 sub_deletions.insert(kSubChunk1); 272 sub_deletions.insert(kSubChunk1);
269 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes, 273 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes,
270 no_deletions, sub_deletions); 274 no_deletions, sub_deletions);
271 275
272 ASSERT_EQ(1U, add_prefixes.size()); 276 ASSERT_EQ(1U, add_prefixes.size());
273 EXPECT_EQ(kAddChunk1, add_prefixes[0].chunk_id); 277 EXPECT_EQ(kAddChunk1, add_prefixes[0].chunk_id);
274 EXPECT_EQ(kHash2.prefix, add_prefixes[0].prefix); 278 EXPECT_EQ(kHash2.prefix, add_prefixes[0].prefix);
275 279
276 ASSERT_EQ(1U, add_hashes.size()); 280 ASSERT_EQ(1U, add_hashes.size());
277 EXPECT_EQ(kAddChunk1, add_hashes[0].chunk_id); 281 EXPECT_EQ(kAddChunk1, add_hashes[0].chunk_id);
278 EXPECT_TRUE(safe_browsing::SBFullHashEqual(kHash6, add_hashes[0].full_hash)); 282 EXPECT_TRUE(SBFullHashEqual(kHash6, add_hashes[0].full_hash));
279 283
280 EXPECT_TRUE(sub_prefixes.empty()); 284 EXPECT_TRUE(sub_prefixes.empty());
281 EXPECT_TRUE(sub_hashes.empty()); 285 EXPECT_TRUE(sub_hashes.empty());
282 286
283 // Delete the adds, also. 287 // Delete the adds, also.
284 base::hash_set<int32> add_deletions; 288 base::hash_set<int32> add_deletions;
285 add_deletions.insert(kAddChunk1); 289 add_deletions.insert(kAddChunk1);
286 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes, 290 ProcessHelper(&add_prefixes, &sub_prefixes, &add_hashes, &sub_hashes,
287 add_deletions, no_deletions); 291 add_deletions, no_deletions);
288 292
289 EXPECT_TRUE(add_prefixes.empty()); 293 EXPECT_TRUE(add_prefixes.empty());
290 EXPECT_TRUE(add_hashes.empty()); 294 EXPECT_TRUE(add_hashes.empty());
291 EXPECT_TRUE(sub_prefixes.empty()); 295 EXPECT_TRUE(sub_prefixes.empty());
292 EXPECT_TRUE(sub_hashes.empty()); 296 EXPECT_TRUE(sub_hashes.empty());
293 } 297 }
294 298
295 TEST(SafeBrowsingStoreTest, Y2K38) { 299 TEST(SafeBrowsingStoreTest, Y2K38) {
296 const base::Time now = base::Time::Now(); 300 const base::Time now = base::Time::Now();
297 const base::Time future = now + base::TimeDelta::FromDays(3*365); 301 const base::Time future = now + base::TimeDelta::FromDays(3*365);
298 302
299 // TODO: Fix file format before 2035. 303 // TODO: Fix file format before 2035.
300 EXPECT_GT(static_cast<int32>(future.ToTimeT()), 0) 304 EXPECT_GT(static_cast<int32>(future.ToTimeT()), 0)
301 << " (int32)time_t is running out."; 305 << " (int32)time_t is running out.";
302 } 306 }
303 307
304 } // namespace 308 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698