Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: content/browser/tracing/background_tracing_config_impl.h

Issue 1420033003: Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purpos… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/background_tracing_config_impl.h
diff --git a/content/browser/tracing/background_tracing_config_impl.h b/content/browser/tracing/background_tracing_config_impl.h
index c3ff85cab1ccd3301e2e826ac7e01d9c9bb59d97..03963b2353b27e922d3711512c5cc564d8ba9269 100644
--- a/content/browser/tracing/background_tracing_config_impl.h
+++ b/content/browser/tracing/background_tracing_config_impl.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_BROWSER_TRACING_BACKGROUND_TRACING_CONFIG_IMPL_H_
#define CONTENT_BROWSER_TRACING_BACKGROUND_TRACING_CONFIG_IMPL_H_
+#include "base/gtest_prod_util.h"
#include "base/memory/scoped_vector.h"
#include "content/common/content_export.h"
#include "content/public/browser/background_tracing_config.h"
@@ -36,6 +37,13 @@ class CONTENT_EXPORT BackgroundTracingConfigImpl
}
const ScopedVector<BackgroundTracingRule>& rules() const { return rules_; }
+ const std::string& scenario_name() const { return scenario_name_; }
+ const std::string& enable_blink_features() const {
+ return enable_blink_features_;
+ }
+ const std::string& disable_blink_features() const {
+ return disable_blink_features_;
+ }
void AddPreemptiveRule(const base::DictionaryValue* dict);
void AddReactiveRule(
@@ -57,8 +65,14 @@ class CONTENT_EXPORT BackgroundTracingConfigImpl
BackgroundTracingConfigImpl::CategoryPreset* category_preset);
private:
+ FRIEND_TEST_ALL_PREFIXES(BackgroundTracingConfigTest,
+ ValidPreemptiveConfigToString);
+
CategoryPreset category_preset_;
ScopedVector<BackgroundTracingRule> rules_;
+ std::string scenario_name_;
+ std::string enable_blink_features_;
+ std::string disable_blink_features_;
DISALLOW_COPY_AND_ASSIGN(BackgroundTracingConfigImpl);
};
« no previous file with comments | « no previous file | content/browser/tracing/background_tracing_config_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698