Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3090)

Unified Diff: chrome/browser/browsing_data/browsing_data_counter.cc

Issue 1420013004: Polish the result communication and display of the browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_counter.cc
diff --git a/chrome/browser/browsing_data/browsing_data_counter.cc b/chrome/browser/browsing_data/browsing_data_counter.cc
index a716c32c90fc4eb61d0e0a2462538f7beedcb2a7..dd0651898845c9fc8496e96fcd26532a5ebaba2b 100644
--- a/chrome/browser/browsing_data/browsing_data_counter.cc
+++ b/chrome/browser/browsing_data/browsing_data_counter.cc
@@ -53,12 +53,51 @@ void BrowsingDataCounter::Restart() {
if (!profile_->GetPrefs()->GetBoolean(GetPrefName()))
return;
- callback_.Run(false, 0u);
+ callback_.Run(make_scoped_ptr(new PendingResult(this)));
Count();
}
void BrowsingDataCounter::ReportResult(ResultInt value) {
DCHECK(initialized_);
- callback_.Run(true, value);
+ callback_.Run(make_scoped_ptr(new FinishedResult(this, value)));
+}
+
+void BrowsingDataCounter::ReportResult(scoped_ptr<Result> result) {
+ DCHECK(initialized_);
+ callback_.Run(result.Pass());
+}
+
+// BrowsingDataCounter::Result -------------------------------------------------
+
+BrowsingDataCounter::Result::Result(
+ const BrowsingDataCounter* source,
+ bool finished,
+ ResultInt value)
+ : source_(source),
+ finished_(finished),
+ value_(value) {
+}
+
+BrowsingDataCounter::Result::~Result() {
+}
+
+// BrowsingDataCounter::FinishedResult -----------------------------------------
+
+BrowsingDataCounter::FinishedResult::FinishedResult(
+ const BrowsingDataCounter* source, ResultInt value)
+ : Result(source, true, value) {
+}
+
+BrowsingDataCounter::FinishedResult::~FinishedResult() {
+}
+
+// BrowsingDataCounter::PendingResult ------------------------------------------
+
+BrowsingDataCounter::PendingResult::PendingResult(
+ const BrowsingDataCounter* source)
+ : Result(source, false, 0) {
+}
+
+BrowsingDataCounter::PendingResult::~PendingResult() {
}

Powered by Google App Engine
This is Rietveld 408576698