Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3700)

Unified Diff: chrome/browser/browsing_data/history_counter.h

Issue 1420013004: Polish the result communication and display of the browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/history_counter.h
diff --git a/chrome/browser/browsing_data/history_counter.h b/chrome/browser/browsing_data/history_counter.h
index f38181c9a0b13d61cf91ba558a0fc1d2ca3666f3..4061cdbdc0ab66c6a5e34e13a449f04c9fc05dac 100644
--- a/chrome/browser/browsing_data/history_counter.h
+++ b/chrome/browser/browsing_data/history_counter.h
@@ -13,11 +13,18 @@
class HistoryCounter: public BrowsingDataCounter {
public:
- // A special value indicating that the local counting result is zero, but some
- // history entries exist in Sync.
- // TODO(msramek): Change the callback signature so we can return a structured
- // result instead of special int values.
- static const BrowsingDataCounter::ResultInt kOnlySyncedHistory;
+ class HistoryResult : public FinishedResult {
+ public:
+ HistoryResult(const HistoryCounter* source,
+ ResultInt value,
+ bool has_synced_visits);
+ ~HistoryResult() override;
+
+ bool has_synced_visits() const { return has_synced_visits_; }
+
+ private:
+ bool has_synced_visits_;
+ };
HistoryCounter();
~HistoryCounter() override;
« no previous file with comments | « chrome/browser/browsing_data/cache_counter_browsertest.cc ('k') | chrome/browser/browsing_data/history_counter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698