Polish the result communication and display of the browsing data counters.

chrome/browser/browsing_data/cache_counter_browsertest.cc

Index: chrome/browser/browsing_data/cache_counter_browsertest.cc
diff --git a/chrome/browser/browsing_data/cache_counter_browsertest.cc b/chrome/browser/browsing_data/cache_counter_browsertest.cc
index a156c73d7aa58edb5ac041bd1a823334a31a88cc..43a97207f32de913b414a1cd3310dcbd98b7688c 100644
--- a/chrome/browser/browsing_data/cache_counter_browsertest.cc
+++ b/chrome/browser/browsing_data/cache_counter_browsertest.cc
@@ -129,11 +129,16 @@ class CacheCounterTest : public InProcessBrowserTest {
   }
 
   // Callback from the counter.
-  void CountingCallback(bool finished, BrowsingDataCounter::ResultInt count) {
+  void CountingCallback(scoped_ptr<BrowsingDataCounter::Result> result) {
     DCHECK_CURRENTLY_ON(BrowserThread::UI);
-    finished_ = finished;
-    result_ = count;
-    if (run_loop_ && finished)
+    finished_ = result->Finished();
+
+    if (finished_) {
+      result_ = static_cast<BrowsingDataCounter::FinishedResult*>(

[Bernhard Bauer, 2015/11/03 14:13:46]

Basically, now anytime you call Value(), the call is guarded by Finished(), so
you could in principle add Value() back on the base class instead. I'll leave
that up to you though.

[msramek, 2015/11/03 14:54:09]

I'll leave it as it is now. We'd get rid of the casts, but not of the additional
Finished() checks anyway, so at least the Result semantics are now clear :)

+          result.get())->Value();
+    }
+
+    if (run_loop_ && finished_)
       run_loop_->Quit();
   }