Support multiline location messages and use signature for function spans.

Support multiline location messages and use signature for function spans.

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/b4f81a216f6776966a8eb1914f31a126143e1e4b

[Johnni Winther, 2015-10-22 13:42:46]

johnniwinther@google.com changed reviewers:
+ ahe@google.com

[ahe, 2015-10-30 13:13:14]

lgtm

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2055: @override
Oh, the horror!

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2057: SourceSpan span =
super.sourcePosition;
Consider renaming to superposition and make a joke about Schrödinger's cat.

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/io/sou...
File pkg/compiler/lib/src/io/source_file.dart (right):

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/io/sou...
pkg/compiler/lib/src/io/source_file.dart:143: var columnEnd = getColumn(lineEnd,
end);
Take this opportunity to add types?

[Johnni Winther, 2015-11-02 10:45:53]

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2055: @override
On 2015/10/30 13:13:14, ahe wrote:
> Oh, the horror!

Oh, the humanity!

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/modelx.dart:2057: SourceSpan span =
super.sourcePosition;
On 2015/10/30 13:13:14, ahe wrote:
> Consider renaming to superposition and make a joke about Schrödinger's cat.

Acknowledged.

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/io/sou...
File pkg/compiler/lib/src/io/source_file.dart (right):

https://codereview.chromium.org/1420013002/diff/1/pkg/compiler/lib/src/io/sou...
pkg/compiler/lib/src/io/source_file.dart:143: var columnEnd = getColumn(lineEnd,
end);
On 2015/10/30 13:13:14, ahe wrote:
> Take this opportunity to add types?

Done.

[Johnni Winther, 2015-11-02 10:52:52]

Committed patchset #2 (id:20001) manually as
b4f81a216f6776966a8eb1914f31a126143e1e4b (presubmit successful).