Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/chromeos/login/login_display_host_impl.h

Issue 14200033: [cros] Rename BaseLoginDisplayHost to LoginDisplayHostImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/login_display_host_impl.h
diff --git a/chrome/browser/chromeos/login/base_login_display_host.h b/chrome/browser/chromeos/login/login_display_host_impl.h
similarity index 86%
rename from chrome/browser/chromeos/login/base_login_display_host.h
rename to chrome/browser/chromeos/login/login_display_host_impl.h
index 203eb1e4b8111c2a8a0193e698d46481f862f3d8..89630a9824ac66723bff8a78785d8f23a0c998f5 100644
--- a/chrome/browser/chromeos/login/base_login_display_host.h
+++ b/chrome/browser/chromeos/login/login_display_host_impl.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_BASE_LOGIN_DISPLAY_HOST_H_
-#define CHROME_BROWSER_CHROMEOS_LOGIN_BASE_LOGIN_DISPLAY_HOST_H_
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_DISPLAY_HOST_IMPL_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_DISPLAY_HOST_IMPL_H_
#include <string>
@@ -15,6 +15,7 @@
#include "chrome/browser/chromeos/settings/device_settings_service.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/web_contents_observer.h"
Denis Kuznetsov (DE-MUC) 2013/04/18 11:14:11 Why do we need it here?
Nikita (slow) 2013/04/18 11:26:17 Good catch, that's part of the upcoming CL, remove
#include "ui/gfx/rect.h"
class PrefService;
@@ -28,13 +29,13 @@ namespace chromeos {
class ExistingUserController;
class WizardController;
-// An abstract base class that defines OOBE/login screen host.
+// An implementation class for OOBE/login screen host.
// It encapsulates controllers, background integration and flow.
-class BaseLoginDisplayHost : public LoginDisplayHost,
+class LoginDisplayHostImpl : public LoginDisplayHost,
public content::NotificationObserver {
public:
- explicit BaseLoginDisplayHost(const gfx::Rect& background_bounds);
- virtual ~BaseLoginDisplayHost();
+ explicit LoginDisplayHostImpl(const gfx::Rect& background_bounds);
+ virtual ~LoginDisplayHostImpl();
// Returns the default LoginDispalyHost instance if it has been created.
static LoginDisplayHost* default_host() {
@@ -91,7 +92,7 @@ class BaseLoginDisplayHost : public LoginDisplayHost,
content::NotificationRegistrar registrar_;
- base::WeakPtrFactory<BaseLoginDisplayHost> pointer_factory_;
+ base::WeakPtrFactory<LoginDisplayHostImpl> pointer_factory_;
// Default LoginDisplayHost.
static LoginDisplayHost* default_host_;
@@ -116,9 +117,9 @@ class BaseLoginDisplayHost : public LoginDisplayHost,
// True if session start is in progress.
bool session_starting_;
- DISALLOW_COPY_AND_ASSIGN(BaseLoginDisplayHost);
+ DISALLOW_COPY_AND_ASSIGN(LoginDisplayHostImpl);
};
} // namespace chromeos
-#endif // CHROME_BROWSER_CHROMEOS_LOGIN_BASE_LOGIN_DISPLAY_HOST_H_
+#endif // CHROME_BROWSER_CHROMEOS_LOGIN_LOGIN_DISPLAY_HOST_IMPL_H_
« no previous file with comments | « chrome/browser/chromeos/login/login_display_host.h ('k') | chrome/browser/chromeos/login/login_display_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698