Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14200033: [cros] Rename BaseLoginDisplayHost to LoginDisplayHostImpl (Closed)

Created:
7 years, 8 months ago by Nikita (slow)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dcheng, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[cros] Rename BaseLoginDisplayHost to LoginDisplayHostImpl Next step: merge WebUILoginDisplayHost into LoginDisplayHostImpl (separate CL). BUG=124218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194894

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : merge #

Total comments: 2

Patch Set 4 : m #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -716 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_launcher.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/base_login_display_host.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 1 chunk +0 lines, -512 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/login/login_display_host_impl.h View 1 3 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/chromeos/login/login_display_host_impl.cc View 1 2 14 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
I've decided to land rename first and then merge WebUILoginDisplayHost into renamed class in a ...
7 years, 8 months ago (2013-04-18 10:59:14 UTC) #1
Denis Kuznetsov (DE-MUC)
lgtm with nit https://codereview.chromium.org/14200033/diff/18001/chrome/browser/chromeos/login/login_display_host_impl.h File chrome/browser/chromeos/login/login_display_host_impl.h (right): https://codereview.chromium.org/14200033/diff/18001/chrome/browser/chromeos/login/login_display_host_impl.h#newcode18 chrome/browser/chromeos/login/login_display_host_impl.h:18: #include "content/public/browser/web_contents_observer.h" Why do we need ...
7 years, 8 months ago (2013-04-18 11:14:11 UTC) #2
Nikita (slow)
https://codereview.chromium.org/14200033/diff/18001/chrome/browser/chromeos/login/login_display_host_impl.h File chrome/browser/chromeos/login/login_display_host_impl.h (right): https://codereview.chromium.org/14200033/diff/18001/chrome/browser/chromeos/login/login_display_host_impl.h#newcode18 chrome/browser/chromeos/login/login_display_host_impl.h:18: #include "content/public/browser/web_contents_observer.h" On 2013/04/18 11:14:11, Denis Kuznetsov wrote: > ...
7 years, 8 months ago (2013-04-18 11:26:17 UTC) #3
Nikita (slow)
7 years, 8 months ago (2013-04-18 12:08:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 manually as r194894.

Powered by Google App Engine
This is Rietveld 408576698