chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc - Issue 14200032: Decouple l10n_util from InputMethodUtil.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 14200032: Decouple l10n_util from InputMethodUtil. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: /MockInputMethodDelegate/FakeInputMethodDelegate/ Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_delegate_impl.cc ('k') | chrome/browser/chromeos/input_method/input_method_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

index 705fa01f36cf456ec6b9c9525fecc8a2fd71ae96..e0e356a1ad5fae24967f80928f057bb545693d43 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -17,9 +17,9 @@

#include "chromeos/dbus/ibus/mock_ibus_input_context_client.h"

#include "chromeos/dbus/mock_dbus_thread_manager_without_gmock.h"

#include "chromeos/ime/extension_ime_util.h"

+#include "chromeos/ime/fake_input_method_delegate.h"

#include "chromeos/ime/mock_component_extension_ime_manager_delegate.h"

#include "chromeos/ime/mock_ibus_daemon_controller.h"

-#include "chromeos/ime/mock_input_method_delegate.h"

#include "chromeos/ime/mock_xkeyboard.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/base/accelerators/accelerator.h"

@@ -52,7 +52,7 @@ class InputMethodManagerImplTest : public testing::Test {

mock_ibus_client_ = mock_dbus_thread_manager_->mock_ibus_client();

mock_ibus_input_context_client_ =

mock_dbus_thread_manager_->mock_ibus_input_context_client();

- delegate_ = new MockInputMethodDelegate();

+ delegate_ = new FakeInputMethodDelegate();

manager_.reset(new InputMethodManagerImpl(

scoped_ptr<InputMethodDelegate>(delegate_)));

controller_ = new MockIBusController;

@@ -113,7 +113,7 @@ class InputMethodManagerImplTest : public testing::Test {

}

scoped_ptr<InputMethodManagerImpl> manager_;

- MockInputMethodDelegate* delegate_;

+ FakeInputMethodDelegate* delegate_;

MockIBusController* controller_;

MockCandidateWindowController* candidate_window_controller_;

MockIBusDaemonController* mock_ibus_daemon_controller_;