Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 14200031: Add more tests of typed data serialization (Closed)

Created:
7 years, 8 months ago by Søren Gjesse
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add more tests of typed data serialization R=asiva@google.com, ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=21665

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -54 lines) Patch
M runtime/vm/snapshot_test.cc View 1 2 chunks +173 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 8 months ago (2013-04-17 12:54:25 UTC) #1
Mads Ager (google)
LGTM
7 years, 8 months ago (2013-04-17 12:58:15 UTC) #2
siva
lgtm https://codereview.chromium.org/14200031/diff/1/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/14200031/diff/1/runtime/vm/snapshot_test.cc#newcode2389 runtime/vm/snapshot_test.cc:2389: root->value.as_array.values[1]->value.as_typed_data.values); Should this be root->value.as_array.values[i] instead of root->value.as_array.values[1] ...
7 years, 8 months ago (2013-04-18 02:19:52 UTC) #3
Søren Gjesse
https://codereview.chromium.org/14200031/diff/1/runtime/vm/snapshot_test.cc File runtime/vm/snapshot_test.cc (right): https://codereview.chromium.org/14200031/diff/1/runtime/vm/snapshot_test.cc#newcode2389 runtime/vm/snapshot_test.cc:2389: root->value.as_array.values[1]->value.as_typed_data.values); On 2013/04/18 02:19:52, siva wrote: > Should this ...
7 years, 8 months ago (2013-04-18 07:28:47 UTC) #4
Søren Gjesse
7 years, 8 months ago (2013-04-18 07:33:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698