Parse motion shorthand in CSSPropertyParser with CSSParserTokens

Parse motion shorthand in CSSPropertyParser with CSSParserTokens

Move motion shorthand property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.

BUG=499780
Committed: https://crrev.com/bb4058ed2ee85b72ca5b952487f5ff5ef779302d
Cr-Commit-Position: refs/heads/master@{#358264}

[rwlbuis, 2015-11-04 03:14:17]

Description was changed from

==========
motion WIP


text-deco WIP

BUG=
==========

to

==========
Parse motion shorthand in CSSPropertyParser with CSSParserTokens

Move motion shorthand property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.
==========

[rwlbuis, 2015-11-04 03:14:48]

Description was changed from

==========
Parse motion shorthand in CSSPropertyParser with CSSParserTokens

Move motion shorthand property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.
==========

to

==========
Parse motion shorthand in CSSPropertyParser with CSSParserTokens

Move motion shorthand property handling from
LegacyCSSPropertyParser into CSSPropertyParser. Also
move its related longhands.

BUG=499780
==========

[rwlbuis, 2015-11-04 03:59:24]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-11-04 03:59:25]

PTAL, this is supposed to go on top of
https://codereview.chromium.org/1412803007/ (whenever that goes in...).

[Timothy Loh, 2015-11-04 04:18:28]

https://codereview.chromium.org/1420003005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1420003005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1525: return
false;
btw we'd never actually get here on the first call ;-)

https://codereview.chromium.org/1420003005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1531:
RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
let's define this where it's used instead of at the top here

https://codereview.chromium.org/1420003005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:1533:
RefPtrWillBeRawPtr<CSSValue> keyword = nullptr;
Another option, WDYT?

RefPtrWillBeRawPtr<CSSValue> angle = consumeAngle(range, cssParserMode);
RefPtrWillBeRawPtr<CSSValue> keyword = consumeIdent<CSSValueAuto,
CSSValueReverse>(range);
if (!angle)
    angle = consumeAngle(range, cssParserMode);

if (!angle && !keyword)
    return nullptr;

[rwlbuis, 2015-11-05 21:58:12]

PTAL, but this one has to go in first:
https://codereview.chromium.org/1405273005/

[Timothy Loh, 2015-11-06 00:00:52]

On 2015/11/05 21:58:12, rwlbuis wrote:
> PTAL, but this one has to go in first:
> https://codereview.chromium.org/1405273005/

lgtm

[rwlbuis, 2015-11-06 04:04:24]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-11-06 04:05:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420003005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420003005/80001

[commit-bot: I haz the power, 2015-11-06 05:22:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-06 05:23:55]

Patchset 5 (id:??) landed as
https://crrev.com/bb4058ed2ee85b72ca5b952487f5ff5ef779302d
Cr-Commit-Position: refs/heads/master@{#358264}