Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14200030: Remove XMLHttpRequestException in favor of DOMException (Closed)

Created:
7 years, 8 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
Reviewers:
jamesr, ojan, eseidel
CC:
blink-reviews, haraken, Nate Chapin, abarth-chromium
Visibility:
Public.

Description

Remove XMLHttpRequestException in favor of DOMException http://www.w3.org/TR/XMLHttpRequest/ XMLHttpRequestException is not implemented on other browsers and it is not in any spec (it was in a spec for a short period in 2007 which happens to be when WebKit added it). BUG=229395 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149663

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Patch Set 4 : Fix tests after rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -271 lines) Patch
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/apply-blob-url-to-xhr-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/appcache/non-html.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/appcache/simple.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/local/fileapi/send-sliced-dragged-file-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/workers/shared-worker-importScripts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/workers/worker-importScripts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestException.html View 2 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-basic-denied-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/connection-error-sync-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt View 1 1 chunk +27 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt View 1 chunk +35 lines, -35 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-android/fast/dom/Window/window-lookup-precedence-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/platform/chromium-mac/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/platform/chromium-win/http/tests/workers/shared-worker-importScripts-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/http/tests/workers/worker-importScripts-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/chromium-win/http/tests/xmlhttprequest/README View 1 chunk +0 lines, -4 lines 0 comments Download
A LayoutTests/platform/chromium-win/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/DOMExceptions.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/DOMWindow.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerContext.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 6 chunks +5 lines, -6 lines 0 comments Download
D Source/core/xml/XMLHttpRequestException.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/xml/XMLHttpRequestException.cpp View 1 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/xml/XMLHttpRequestException.idl View 1 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
arv (Not doing code reviews)
7 years, 7 months ago (2013-05-03 16:41:05 UTC) #1
jamesr
lgtm on the code change
7 years, 7 months ago (2013-05-03 17:47:37 UTC) #2
ojan
lgtm
7 years, 7 months ago (2013-05-03 17:52:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14200030/10001
7 years, 7 months ago (2013-05-03 18:17:37 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-03 19:10:22 UTC) #5
Message was sent while issue was closed. 
Change committed as 149663

Powered by Google App Engine
This is Rietveld 408576698