Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 14200028: Make CrosSettings and DeviceSettingsService non Lazy instances (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix LoginUtilsTest Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chromeos/settings/device_settings_service.cc ('K') | « chrome/browser/chromeos/settings/device_settings_service.cc ('k') | chrome/browser/chromeos/settings/device_settings_test_helper.h » ('j') | chrome/browser/chromeos/settings/device_settings_test_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/settings/device_settings_service_unittest.cc
diff --git a/chrome/browser/chromeos/settings/device_settings_service_unittest.cc b/chrome/browser/chromeos/settings/device_settings_service_unittest.cc
index 539d7c5d53a1cd74bf39f23f8409b1e870e271b1..843afd9a088ae734d37ef4cf0da67d6c455502f3 100644
--- a/chrome/browser/chromeos/settings/device_settings_service_unittest.cc
+++ b/chrome/browser/chromeos/settings/device_settings_service_unittest.cc
@@ -58,12 +58,12 @@ class DeviceSettingsServiceTest : public DeviceSettingsTestBase {
}
void CheckPolicy() {
- ASSERT_TRUE(device_settings_service_.policy_data());
+ ASSERT_TRUE(device_settings_service_->policy_data());
EXPECT_EQ(device_policy_.policy_data().SerializeAsString(),
- device_settings_service_.policy_data()->SerializeAsString());
- ASSERT_TRUE(device_settings_service_.device_settings());
+ device_settings_service_->policy_data()->SerializeAsString());
+ ASSERT_TRUE(device_settings_service_->device_settings());
EXPECT_EQ(device_policy_.payload().SerializeAsString(),
- device_settings_service_.device_settings()->SerializeAsString());
+ device_settings_service_->device_settings()->SerializeAsString());
}
bool operation_completed_;
@@ -79,9 +79,9 @@ TEST_F(DeviceSettingsServiceTest, LoadNoKey) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
- device_settings_service_.status());
- EXPECT_FALSE(device_settings_service_.policy_data());
- EXPECT_FALSE(device_settings_service_.device_settings());
+ device_settings_service_->status());
+ EXPECT_FALSE(device_settings_service_->policy_data());
+ EXPECT_FALSE(device_settings_service_->device_settings());
}
TEST_F(DeviceSettingsServiceTest, LoadNoPolicy) {
@@ -89,9 +89,9 @@ TEST_F(DeviceSettingsServiceTest, LoadNoPolicy) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_NO_POLICY,
- device_settings_service_.status());
- EXPECT_FALSE(device_settings_service_.policy_data());
- EXPECT_FALSE(device_settings_service_.device_settings());
+ device_settings_service_->status());
+ EXPECT_FALSE(device_settings_service_->policy_data());
+ EXPECT_FALSE(device_settings_service_->device_settings());
}
TEST_F(DeviceSettingsServiceTest, LoadValidationError) {
@@ -101,9 +101,9 @@ TEST_F(DeviceSettingsServiceTest, LoadValidationError) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_VALIDATION_ERROR,
- device_settings_service_.status());
- EXPECT_FALSE(device_settings_service_.policy_data());
- EXPECT_FALSE(device_settings_service_.device_settings());
+ device_settings_service_->status());
+ EXPECT_FALSE(device_settings_service_->policy_data());
+ EXPECT_FALSE(device_settings_service_->device_settings());
}
TEST_F(DeviceSettingsServiceTest, LoadValidationErrorFutureTimestamp) {
@@ -117,46 +117,47 @@ TEST_F(DeviceSettingsServiceTest, LoadValidationErrorFutureTimestamp) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_TEMP_VALIDATION_ERROR,
- device_settings_service_.status());
- EXPECT_FALSE(device_settings_service_.policy_data());
- EXPECT_FALSE(device_settings_service_.device_settings());
+ device_settings_service_->status());
+ EXPECT_FALSE(device_settings_service_->policy_data());
+ EXPECT_FALSE(device_settings_service_->device_settings());
}
TEST_F(DeviceSettingsServiceTest, LoadSuccess) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
CheckPolicy();
}
TEST_F(DeviceSettingsServiceTest, SignAndStoreNoKey) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
scoped_ptr<em::ChromeDeviceSettingsProto> new_device_settings(
new em::ChromeDeviceSettingsProto(device_policy_.payload()));
new_device_settings->mutable_device_policy_refresh_rate()->
set_device_policy_refresh_rate(300);
- device_settings_service_.SignAndStore(
+ device_settings_service_->SignAndStore(
new_device_settings.Pass(),
base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
base::Unretained(this)));
FlushDeviceSettings();
EXPECT_TRUE(operation_completed_);
EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
- device_settings_service_.status());
+ device_settings_service_->status());
CheckPolicy();
}
TEST_F(DeviceSettingsServiceTest, SignAndStoreFailure) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
owner_key_util_->SetPrivateKey(device_policy_.signing_key());
- device_settings_service_.SetUsername(device_policy_.policy_data().username());
+ device_settings_service_->SetUsername(
+ device_policy_.policy_data().username());
FlushDeviceSettings();
scoped_ptr<em::ChromeDeviceSettingsProto> new_device_settings(
@@ -164,30 +165,31 @@ TEST_F(DeviceSettingsServiceTest, SignAndStoreFailure) {
new_device_settings->mutable_device_policy_refresh_rate()->
set_device_policy_refresh_rate(300);
device_settings_test_helper_.set_store_result(false);
- device_settings_service_.SignAndStore(
+ device_settings_service_->SignAndStore(
new_device_settings.Pass(),
base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
base::Unretained(this)));
FlushDeviceSettings();
EXPECT_TRUE(operation_completed_);
EXPECT_EQ(DeviceSettingsService::STORE_OPERATION_FAILED,
- device_settings_service_.status());
+ device_settings_service_->status());
CheckPolicy();
}
TEST_F(DeviceSettingsServiceTest, SignAndStoreSuccess) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
owner_key_util_->SetPrivateKey(device_policy_.signing_key());
- device_settings_service_.SetUsername(device_policy_.policy_data().username());
+ device_settings_service_->SetUsername(
+ device_policy_.policy_data().username());
FlushDeviceSettings();
device_policy_.payload().mutable_device_policy_refresh_rate()->
set_device_policy_refresh_rate(300);
device_policy_.Build();
- device_settings_service_.SignAndStore(
+ device_settings_service_->SignAndStore(
scoped_ptr<em::ChromeDeviceSettingsProto>(
new em::ChromeDeviceSettingsProto(device_policy_.payload())),
base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
@@ -195,10 +197,10 @@ TEST_F(DeviceSettingsServiceTest, SignAndStoreSuccess) {
FlushDeviceSettings();
EXPECT_TRUE(operation_completed_);
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
- ASSERT_TRUE(device_settings_service_.device_settings());
+ device_settings_service_->status());
+ ASSERT_TRUE(device_settings_service_->device_settings());
EXPECT_EQ(device_policy_.payload().SerializeAsString(),
- device_settings_service_.device_settings()->SerializeAsString());
+ device_settings_service_->device_settings()->SerializeAsString());
}
TEST_F(DeviceSettingsServiceTest, StoreFailure) {
@@ -206,17 +208,17 @@ TEST_F(DeviceSettingsServiceTest, StoreFailure) {
device_settings_test_helper_.set_policy_blob(std::string());
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
- device_settings_service_.status());
+ device_settings_service_->status());
device_settings_test_helper_.set_store_result(false);
- device_settings_service_.Store(
+ device_settings_service_->Store(
device_policy_.GetCopy(),
base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
base::Unretained(this)));
FlushDeviceSettings();
EXPECT_TRUE(operation_completed_);
EXPECT_EQ(DeviceSettingsService::STORE_OPERATION_FAILED,
- device_settings_service_.status());
+ device_settings_service_->status());
}
TEST_F(DeviceSettingsServiceTest, StoreSuccess) {
@@ -224,98 +226,99 @@ TEST_F(DeviceSettingsServiceTest, StoreSuccess) {
device_settings_test_helper_.set_policy_blob(std::string());
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_KEY_UNAVAILABLE,
- device_settings_service_.status());
+ device_settings_service_->status());
owner_key_util_->SetPublicKeyFromPrivateKey(device_policy_.signing_key());
- device_settings_service_.Store(
+ device_settings_service_->Store(
device_policy_.GetCopy(),
base::Bind(&DeviceSettingsServiceTest::SetOperationCompleted,
base::Unretained(this)));
FlushDeviceSettings();
EXPECT_TRUE(operation_completed_);
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
CheckPolicy();
}
TEST_F(DeviceSettingsServiceTest, StoreRotation) {
ReloadDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
device_policy_.payload().mutable_device_policy_refresh_rate()->
set_device_policy_refresh_rate(300);
device_policy_.set_new_signing_key(
policy::PolicyBuilder::CreateTestNewSigningKey());
device_policy_.Build();
- device_settings_service_.Store(device_policy_.GetCopy(), base::Closure());
+ device_settings_service_->Store(device_policy_.GetCopy(), base::Closure());
FlushDeviceSettings();
owner_key_util_->SetPublicKeyFromPrivateKey(device_policy_.new_signing_key());
- device_settings_service_.OwnerKeySet(true);
+ device_settings_service_->OwnerKeySet(true);
FlushDeviceSettings();
EXPECT_EQ(DeviceSettingsService::STORE_SUCCESS,
- device_settings_service_.status());
+ device_settings_service_->status());
CheckPolicy();
// Check the new key has been loaded.
std::vector<uint8> key;
ASSERT_TRUE(device_policy_.new_signing_key()->ExportPublicKey(&key));
- EXPECT_EQ(*device_settings_service_.GetOwnerKey()->public_key(), key);
+ EXPECT_EQ(*device_settings_service_->GetOwnerKey()->public_key(), key);
}
TEST_F(DeviceSettingsServiceTest, OwnershipStatus) {
owner_key_util_->Clear();
- EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
- EXPECT_FALSE(device_settings_service_.GetOwnerKey());
+ EXPECT_FALSE(device_settings_service_->HasPrivateOwnerKey());
+ EXPECT_FALSE(device_settings_service_->GetOwnerKey());
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
- device_settings_service_.GetOwnershipStatus());
+ device_settings_service_->GetOwnershipStatus());
- device_settings_service_.GetOwnershipStatusAsync(
+ device_settings_service_->GetOwnershipStatusAsync(
base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus,
base::Unretained(this)));
FlushDeviceSettings();
- EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
- ASSERT_TRUE(device_settings_service_.GetOwnerKey());
- EXPECT_FALSE(device_settings_service_.GetOwnerKey()->public_key());
- EXPECT_FALSE(device_settings_service_.GetOwnerKey()->private_key());
+ EXPECT_FALSE(device_settings_service_->HasPrivateOwnerKey());
+ ASSERT_TRUE(device_settings_service_->GetOwnerKey());
+ EXPECT_FALSE(device_settings_service_->GetOwnerKey()->public_key());
+ EXPECT_FALSE(device_settings_service_->GetOwnerKey()->private_key());
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_NONE,
- device_settings_service_.GetOwnershipStatus());
+ device_settings_service_->GetOwnershipStatus());
EXPECT_FALSE(is_owner_);
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_NONE, ownership_status_);
owner_key_util_->SetPublicKeyFromPrivateKey(device_policy_.signing_key());
ReloadDeviceSettings();
- device_settings_service_.GetOwnershipStatusAsync(
+ device_settings_service_->GetOwnershipStatusAsync(
base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus,
base::Unretained(this)));
FlushDeviceSettings();
- EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
- ASSERT_TRUE(device_settings_service_.GetOwnerKey());
- ASSERT_TRUE(device_settings_service_.GetOwnerKey()->public_key());
+ EXPECT_FALSE(device_settings_service_->HasPrivateOwnerKey());
+ ASSERT_TRUE(device_settings_service_->GetOwnerKey());
+ ASSERT_TRUE(device_settings_service_->GetOwnerKey()->public_key());
std::vector<uint8> key;
ASSERT_TRUE(device_policy_.signing_key()->ExportPublicKey(&key));
- EXPECT_EQ(*device_settings_service_.GetOwnerKey()->public_key(), key);
- EXPECT_FALSE(device_settings_service_.GetOwnerKey()->private_key());
+ EXPECT_EQ(*device_settings_service_->GetOwnerKey()->public_key(), key);
+ EXPECT_FALSE(device_settings_service_->GetOwnerKey()->private_key());
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
- device_settings_service_.GetOwnershipStatus());
+ device_settings_service_->GetOwnershipStatus());
EXPECT_FALSE(is_owner_);
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
owner_key_util_->SetPrivateKey(device_policy_.signing_key());
- device_settings_service_.SetUsername(device_policy_.policy_data().username());
- device_settings_service_.GetOwnershipStatusAsync(
+ device_settings_service_->SetUsername(
+ device_policy_.policy_data().username());
+ device_settings_service_->GetOwnershipStatusAsync(
base::Bind(&DeviceSettingsServiceTest::SetOwnershipStatus,
base::Unretained(this)));
FlushDeviceSettings();
- EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
- ASSERT_TRUE(device_settings_service_.GetOwnerKey());
- ASSERT_TRUE(device_settings_service_.GetOwnerKey()->public_key());
+ EXPECT_TRUE(device_settings_service_->HasPrivateOwnerKey());
+ ASSERT_TRUE(device_settings_service_->GetOwnerKey());
+ ASSERT_TRUE(device_settings_service_->GetOwnerKey()->public_key());
ASSERT_TRUE(device_policy_.signing_key()->ExportPublicKey(&key));
- EXPECT_EQ(*device_settings_service_.GetOwnerKey()->public_key(), key);
- EXPECT_TRUE(device_settings_service_.GetOwnerKey()->private_key());
+ EXPECT_EQ(*device_settings_service_->GetOwnerKey()->public_key(), key);
+ EXPECT_TRUE(device_settings_service_->GetOwnerKey()->private_key());
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
- device_settings_service_.GetOwnershipStatus());
+ device_settings_service_->GetOwnershipStatus());
EXPECT_TRUE(is_owner_);
EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, ownership_status_);
}
@@ -323,7 +326,7 @@ TEST_F(DeviceSettingsServiceTest, OwnershipStatus) {
TEST_F(DeviceSettingsServiceTest, Observer) {
owner_key_util_->Clear();
MockDeviceSettingsObserver observer_;
- device_settings_service_.AddObserver(&observer_);
+ device_settings_service_->AddObserver(&observer_);
EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(1);
EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
@@ -338,17 +341,17 @@ TEST_F(DeviceSettingsServiceTest, Observer) {
EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
- device_settings_service_.Store(device_policy_.GetCopy(), base::Closure());
+ device_settings_service_->Store(device_policy_.GetCopy(), base::Closure());
FlushDeviceSettings();
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
- device_settings_service_.PropertyChangeComplete(true);
+ device_settings_service_->PropertyChangeComplete(true);
FlushDeviceSettings();
Mock::VerifyAndClearExpectations(&observer_);
- device_settings_service_.RemoveObserver(&observer_);
+ device_settings_service_->RemoveObserver(&observer_);
}
} // namespace chromeos
« chrome/browser/chromeos/settings/device_settings_service.cc ('K') | « chrome/browser/chromeos/settings/device_settings_service.cc ('k') | chrome/browser/chromeos/settings/device_settings_test_helper.h » ('j') | chrome/browser/chromeos/settings/device_settings_test_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698