Make CrosSettings and DeviceSettingsService non Lazy instances

chrome/browser/browser_process_impl.cc

Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index f23eced67b9c39cb3357f70914b259eb3e5da4af..365f662b1fefa8fc24d635dfa5e28761f6bc78d0 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -116,6 +116,7 @@
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/memory/oom_priority_manager.h"
+#include "chrome/browser/chromeos/settings/cros_settings.h"
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(ENABLE_PLUGIN_INSTALLATION)
@@ -204,6 +205,11 @@ BrowserProcessImpl::~BrowserProcessImpl() {
   tracked_objects::ThreadData::EnsureCleanupWasCalled(4);
 
   g_browser_process = NULL;
+
+#if defined(OS_CHROMEOS)
+  // Initialized in PreCreateThreards()
+  chromeos::CrosSettings::Shutdown();
+#endif
 }
 
 void BrowserProcessImpl::StartTearDown() {
@@ -852,6 +858,9 @@ void BrowserProcessImpl::CreateLocalState() {
 }
 
 void BrowserProcessImpl::PreCreateThreads() {
+#if defined(OS_CHROMEOS)
+  chromeos::CrosSettings::Initialize();

[Mattias Nissler (ping if slow), 2013/04/16 16:09:51]

Why is this not in chrome_browser_main_chromeos.cc?

[stevenjb, 2013/04/16 16:49:43]

new BrowserProcessImpl() and browser_process_->PreCreateThreads() are both
called in ChromeBrowserMainParts::PreCreateThreadsImpl()

CrosSettings has to be created after g_browser_process because constructing it
references g_browser_process as follows:

CrosSettings::CrosSettings() ->
DeviceSettingsProvider::DeviceSettingsProvider() ->
DeviceSettingsProvider::RetrieveCachedData()

I could put this into ChromeBrowserMainParts::PreCreateThreadsImpl() instead if
that seems better? I suppose I *could* subdivide PreCreateThreads into two
phases, but I'd prefer to avoid combining that level of re-factoring with this.

[Mattias Nissler (ping if slow), 2013/04/16 18:04:13]

Right, and IOThread initialization below immediately makes the first call to
CrosSettings, so we can't move it later in the init sequence either. Hrmpf,
don't know a better solution then without going down more rabbit holes.

+#endif
   io_thread_.reset(new IOThread(local_state(), policy_service(), net_log_.get(),
                                 extension_event_router_forwarder_.get()));
 }