Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 14200014: Increase profiling interval in test-cpu-profiler/CollectCpuProfile to 500ms on Windows (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
Sven Panne, alph, loislo
CC:
chromium-reviews
Visibility:
Public.

Description

Increase profiling interval in test-cpu-profiler/CollectCpuProfile to 500ms on Windows BUG=v8:2628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=14266

Patch Set 1 #

Patch Set 2 : Added _WIN64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M test/cctest/test-cpu-profiler.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
7 years, 8 months ago (2013-04-15 14:17:34 UTC) #1
yurys
7 years, 8 months ago (2013-04-15 14:18:08 UTC) #2
loislo
lgtm
7 years, 8 months ago (2013-04-15 14:35:56 UTC) #3
Sven Panne
LGTM, too. Nevertheless, finding out why we have to bump the interval on Windows only ...
7 years, 8 months ago (2013-04-15 14:38:12 UTC) #4
yurys
7 years, 8 months ago (2013-04-15 14:45:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14266 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698