Issue 14200011: Cleanup: Return additional schemes vector as out parameter from GetAdditionalWebUISchemes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14200011: Cleanup: Return additional schemes vector as out parameter from GetAdditionalWebUISchemes (Closed)

Created:
7 years, 8 months ago by kinuko

Modified:
7 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup: Return additional schemes vector as out parameter from GetAdditionalWebUISchemes Changing ContentBrowserClient::GetAdditionalAllowedSchemesForFileSystem() not to return std::vector<std::string> as return value (but as an out parameter) to follow the coding convention. A follow-up patch for https://chromiumcodereview.appspot.com/13415006 BUG=none TEST=no new tests as no behavioral changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194519

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -16 lines)			Patch
M	chrome/browser/chrome_content_browser_client.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	content/browser/storage_partition_impl_map.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/webui/url_data_manager_backend.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/public/browser/content_browser_client.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinuko

Cleanup-only change (as a follow-up for https://codereview.chromium.org/13415006/). Can you take a look? Thx,

7 years, 8 months ago (2013-04-15 15:31:42 UTC) #1

kinuko

7 years, 8 months ago (2013-04-17 02:35:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r194519 (presubmit successful).

Expand Messages | Collapse Messages