chrome: Rename WrenchMenuController to AppMenuController.

chrome: Rename WrenchMenuController to AppMenuController.

The wrench icon has been gone for a long time now, the new icon is a
sideways ellipsis called browser_tools. And it is now known by app menu.

BUG=None
R=pkasting@chromium.org,avi@chromium.org
TBR=thestig@chromium.org # for gyp changes in chrome/

Committed: https://crrev.com/9e4b75e7bd1916fc4fabbc2da2a69282ff6169e2
Cr-Commit-Position: refs/heads/master@{#358970}

[tfarina, 2015-11-06 17:45:09]

Avi, ptal at the cocoa bits.

Peter, everything.

Thanks,

[Avi (use Gerrit), 2015-11-06 20:27:44]

LGTM ¯\_(ツ)_/¯

Note that your build broke on the Mac because the file changed out from under
you. You'll have to move those changes too.

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/app_menu/app_menu_controller.h (right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller.h:23: class AppMenuModel;
Alphabetize this mess. (Not your fault, I know.)

[Peter Kasting, 2015-11-06 22:21:28]

LGTM

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/app_menu/app_menu_controller.h (right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller.h:36: // The App menu has a
creative layout, with buttons in menu items. There is
Nit: Rewrap comments

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm (right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm:207: // (This is fine
because we re-populate the app menu each time before
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm:400: // The custom views
within the App menu are abnormal and keep the menu
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller.mm:524: // Start searching
at the app menu model level, |model| will be updated
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm (right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm:253: // Test
that AppMenuController can be destroyed after the Browser.
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/browser_action_button.mm (right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:157: // The point
the menu shows matches that of the normal app menu - that is,
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button.mm:233: // context menu
for an overflowed action, we close the app menu and show
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
(right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:190:
// app menu). Instead, simulate a right click by feeding the event directly
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:272:
// Click on the app menu, and pass in a callback to continue the test
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:379:
// Click on the app menu, and pass in a callback to continue the test
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:397:
// Adding a global error adjusts the app menu size, and has been known
Nit: Rewrap comment

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
(right):

https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm:84:
// If this was triggered by an action overflowed to the app menu, then
Nit: Rewrap comment

[tfarina, 2015-11-06 23:00:44]

On 2015/11/06 20:27:44, Avi wrote:
> LGTM ¯\_(ツ)_/¯
> 
> Note that your build broke on the Mac because the file changed out from under
> you. You'll have to move those changes too.
Avi, could you give me more details? I have no idea how to fix the Mac breakage.
I'm just getting started with the mac build. ;)

> 
>
https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/app_menu/app_menu_controller.h (right):
> 
>
https://codereview.chromium.org/1419993010/diff/40001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/app_menu/app_menu_controller.h:23: class AppMenuModel;
> Alphabetize this mess. (Not your fault, I know.)
I will clean it :)

[Avi (use Gerrit), 2015-11-07 15:52:57]

On 2015/11/06 23:00:44, tfarina wrote:
> On 2015/11/06 20:27:44, Avi wrote:
> > Note that your build broke on the Mac because the file changed out from
under
> > you. You'll have to move those changes too.
> Avi, could you give me more details? I have no idea how to fix the Mac
breakage.
> I'm just getting started with the mac build. ;)

What I meant was that you moved wrench_menu_controller.mm to
app_menu_controller.mm and that's this patch. But right after you uploaded this
patch, someone changed wrench_menu_controller.mm. See
https://chromium.googlesource.com/chromium/src/+/bd7bc5a7d793e805db45ef7de827...
. You're going to have to apply that patch to yours, or just re-do the move
including their change.

(It's not a Mac thing, just the fun of working in a DVCS.)

[tfarina, 2015-11-10 22:25:17]

tfarina@chromium.org changed reviewers:
+ thestig@chromium.org

[tfarina, 2015-11-10 22:25:18]

TBRing Lei for the gyp changes in chrome/

[tfarina, 2015-11-10 22:25:45]

Description was changed from

==========
chrome: Rename WrenchMenuController to AppMenuController.

The wrench icon has been gone for a long time now, the new icon is a
sideways ellipsis called browser_tools. And it is now known by app menu.

BUG=None
R=pkasting@chromium.org,avi@chromium.org
==========

to

==========
chrome: Rename WrenchMenuController to AppMenuController.

The wrench icon has been gone for a long time now, the new icon is a
sideways ellipsis called browser_tools. And it is now known by app menu.

BUG=None
R=pkasting@chromium.org,avi@chromium.org
TBR=thestig@chromium.org # for gyp changes in chrome/
==========

[tfarina, 2015-11-10 22:25:53]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-11-10 22:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1419993010/#ps80001
(title: "rewrap comments")

[commit-bot: I haz the power, 2015-11-10 22:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419993010/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419993010/80001

[Lei Zhang, 2015-11-10 22:33:14]

rs lgtm

[commit-bot: I haz the power, 2015-11-11 00:22:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-11 00:23:27]

Patchset 5 (id:??) landed as
https://crrev.com/9e4b75e7bd1916fc4fabbc2da2a69282ff6169e2
Cr-Commit-Position: refs/heads/master@{#358970}