Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1419983003: Add support for decoding URL-safe encoded base64. (Closed)

Created:
5 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org, mit
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for decoding URL-safe encoded base64. Also support "%3D" instead of "=" as padding, but no other percent escapes. This is only for decoding, encoding is still as strict as possible. R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/289a22182e629e7e4f9085e3807ca0256dad5769

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Patch Set 3 : Fix assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -65 lines) Patch
M sdk/lib/convert/base64.dart View 1 2 6 chunks +127 lines, -33 lines 0 comments Download
M tests/lib/convert/base64_test.dart View 6 chunks +53 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 2 months ago (2015-10-22 09:34:17 UTC) #2
nweiz
lgtm https://codereview.chromium.org/1419983003/diff/1/sdk/lib/convert/base64.dart File sdk/lib/convert/base64.dart (right): https://codereview.chromium.org/1419983003/diff/1/sdk/lib/convert/base64.dart#newcode574 sdk/lib/convert/base64.dart:574: * it needs when input is valid, and ...
5 years, 2 months ago (2015-10-22 20:14:30 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1419983003/diff/1/sdk/lib/convert/base64.dart File sdk/lib/convert/base64.dart (right): https://codereview.chromium.org/1419983003/diff/1/sdk/lib/convert/base64.dart#newcode574 sdk/lib/convert/base64.dart:574: * it needs when input is valid, and at ...
5 years, 2 months ago (2015-10-23 11:03:35 UTC) #4
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-10-26 08:41:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
289a22182e629e7e4f9085e3807ca0256dad5769 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698