Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1419973003: generate an html report of the compilation results (Closed)

Created:
5 years, 1 month ago by devoncarew
Modified:
5 years, 1 month ago
Reviewers:
vsm, Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

generate an html report of the compilation results cleanup css BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/17e1ebe546a9c7c05edf39c3e76c3bc5bebd7486

Patch Set 1 #

Total comments: 8

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -3 lines) Patch
M lib/src/compiler.dart View 1 3 chunks +6 lines, -3 lines 0 comments Download
M lib/src/options.dart View 5 chunks +8 lines, -0 lines 0 comments Download
A lib/src/report/html_gen.dart View 1 1 chunk +150 lines, -0 lines 0 comments Download
A lib/src/report/html_reporter.dart View 1 1 chunk +525 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
devoncarew
Here's the patch to generate an html report of the ddc errors, warnings (and any ...
5 years, 1 month ago (2015-10-27 18:29:44 UTC) #2
vsm
lgtm! https://codereview.chromium.org/1419973003/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://codereview.chromium.org/1419973003/diff/1/lib/src/compiler.dart#newcode72 lib/src/compiler.dart:72: (reporter as HtmlReporter).finish(options); You might not need the ...
5 years, 1 month ago (2015-10-27 20:04:55 UTC) #3
devoncarew
Thanks! Updated. https://codereview.chromium.org/1419973003/diff/1/lib/src/compiler.dart File lib/src/compiler.dart (right): https://codereview.chromium.org/1419973003/diff/1/lib/src/compiler.dart#newcode72 lib/src/compiler.dart:72: (reporter as HtmlReporter).finish(options); On 2015/10/27 20:04:55, vsm ...
5 years, 1 month ago (2015-10-27 20:32:35 UTC) #4
vsm
lgtm
5 years, 1 month ago (2015-10-28 12:41:38 UTC) #5
devoncarew
5 years, 1 month ago (2015-10-28 16:57:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
17e1ebe546a9c7c05edf39c3e76c3bc5bebd7486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698