Fix the error message widget

lib/src/summary.dart

Index: lib/src/summary.dart
diff --git a/lib/src/summary.dart b/lib/src/summary.dart
index fc50707798649c272040f5dca8dac31daa7f8041..3a4601a4b513b96e184e834dfefccabe92c98933 100644
--- a/lib/src/summary.dart
+++ b/lib/src/summary.dart
@@ -7,8 +7,6 @@ library dev_compiler.src.summary;
 
 import 'dart:collection' show HashSet;
 
-import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
-import 'package:analyzer/src/generated/source.dart' show Source;

[vsm, 2015/10/21 22:37:09]

This file is used by the widget, so need to minimize deps.  Perhaps we should
move it to the runtime directory?

 import 'package:source_span/source_span.dart';
 
 /// Summary information computed by the DDC checker.
@@ -123,15 +121,14 @@ class LibrarySummary implements IndividualSummary {
         'lines': lines,
       };
 
-  void countSourceLines(AnalysisContext context, Source source) {
-    if (_uris.add(source.uri)) {
+  void recordSourceLines(Uri uri, int computeLines()) {
+    if (_uris.add(uri)) {
       // TODO(jmesserly): parsing is serious overkill for this.
       // Should be cached, but still.
       // On the other hand, if we are going to parse, we could get a much better
       // source lines of code estimate by excluding things like comments,
       // blank lines, and closing braces.
-      var unit = context.parseCompilationUnit(source);
-      _lines += unit.lineInfo.getLocation(unit.endToken.end).lineNumber;
+      _lines += computeLines();
     }
   }
 
@@ -139,7 +136,8 @@ class LibrarySummary implements IndividualSummary {
 
   static LibrarySummary parse(Map json) =>
       new LibrarySummary(json['library_name'],
-          messages: json['messages'].map(MessageSummary.parse).toList(),
+          messages: new List<MessageSummary>.from(
+              json['messages'].map(MessageSummary.parse)),
           lines: json['lines']);
 }
 
@@ -160,7 +158,9 @@ class HtmlSummary implements IndividualSummary {
   void accept(SummaryVisitor visitor) => visitor.visitHtml(this);
 
   static HtmlSummary parse(Map json) => new HtmlSummary(
-      json['name'], json['messages'].map(MessageSummary.parse).toList());
+      json['name'],
+      new List<MessageSummary>.from(
+          json['messages'].map(MessageSummary.parse)));
 }
 
 /// A single message produced by the checker.