Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1419953002: Fix the error message widget (Closed)

Created:
5 years, 2 months ago by vsm
Modified:
5 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13132 lines, -6572 lines) Patch
M lib/runtime/messages.css View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/messages_widget.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/runtime/messages_widget.js View 6 chunks +13108 lines, -6552 lines 0 comments Download
M lib/src/report.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M lib/src/server/server.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/src/summary.dart View 1 4 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vsm
https://codereview.chromium.org/1419953002/diff/1/lib/src/summary.dart File lib/src/summary.dart (left): https://codereview.chromium.org/1419953002/diff/1/lib/src/summary.dart#oldcode11 lib/src/summary.dart:11: import 'package:analyzer/src/generated/source.dart' show Source; This file is used by ...
5 years, 2 months ago (2015-10-21 22:37:09 UTC) #3
vsm
ping
5 years, 1 month ago (2015-10-27 15:10:05 UTC) #4
Jennifer Messerly
lgtm
5 years, 1 month ago (2015-10-27 16:24:28 UTC) #5
vsm
5 years, 1 month ago (2015-10-27 18:31:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7493acf288d35ecfa767083c4a0ef943cb1710db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698