Issue 1419943003: Add Observatory BUILD.gn rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1419943003: Add Observatory BUILD.gn rules (Closed)

Created:
5 years, 1 month ago by Cutch

Modified:
5 years, 1 month ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add Observatory BUILD.gn rules BUG= Committed: https://github.com/dart-lang/sdk/commit/1b9f7bca1c33a6d85388ebac2b9fb5a367c6bc9a

Patch Set 1 #

Total comments: 4

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -0 lines)			Patch
	A	runtime/observatory/BUILD.gn	View		1 chunk	+183 lines, -0 lines	4 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #1 (id:1) manually as 1b9f7bca1c33a6d85388ebac2b9fb5a367c6bc9a (presubmit successful).

5 years, 1 month ago (2015-10-26 21:18:54 UTC) #3

rmacnak

5 years, 1 month ago (2015-10-26 22:17:24 UTC) #5

Message was sent while issue was closed.

lgtm w/c

https://codereview.chromium.org/1419943003/diff/1/runtime/observatory/BUILD.gn
File runtime/observatory/BUILD.gn (right):

https://codereview.chromium.org/1419943003/diff/1/runtime/observatory/BUILD.g...
runtime/observatory/BUILD.gn:13: dart_host_pub_exe =
rebase_path("$dart_host_sdk/pub")
$dart_host_sdk/bin/pub

https://codereview.chromium.org/1419943003/diff/1/runtime/observatory/BUILD.g...
runtime/observatory/BUILD.gn:79:
rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
$dart_host_pub_exe

https://codereview.chromium.org/1419943003/diff/1/runtime/observatory/BUILD.g...
runtime/observatory/BUILD.gn:112:
rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
$dart_host_pub_exe

https://codereview.chromium.org/1419943003/diff/1/runtime/observatory/BUILD.g...
runtime/observatory/BUILD.gn:142:
rebase_path("//third_party/dart-sdk/dart-sdk/bin/pub"),
$dart_host_pub_exe

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages