Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "platform/graphics/GraphicsLayerDebugInfo.h"
 
-#include "public/platform/WebGraphicsLayerDebugInfo.h"
+#include "base/trace_event/trace_event_argument.h"
 #include "wtf/text/CString.h"
 
 namespace blink {
 
 GraphicsLayerDebugInfo::GraphicsLayerDebugInfo()
     : m_compositingReasons(CompositingReasonNone)
     , m_ownerNodeId(0)
 {
 }
 
 GraphicsLayerDebugInfo::~GraphicsLayerDebugInfo() { }
 
-void GraphicsLayerDebugInfo::appendAsTraceFormat(WebString* out) const
+scoped_refptr<base::trace_event::TracedValue> GraphicsLayerDebugInfo::asTracedValue() const
 {
-    RefPtr<JSONObject> jsonObject = JSONObject::create();
-    appendAnnotatedInvalidateRects(jsonObject.get());
-    appendCompositingReasons(jsonObject.get());
-    appendDebugName(jsonObject.get());
-    appendOwnerNodeId(jsonObject.get());
-    *out = jsonObject->toJSONString();
+    scoped_refptr<base::trace_event::TracedValue> tracedValue = new base::trace_event::TracedValue;
+    appendAnnotatedInvalidateRects(tracedValue.get());
+    appendCompositingReasons(tracedValue.get());
+    appendOwnerNodeId(tracedValue.get());
+    return tracedValue;
 }
 
-GraphicsLayerDebugInfo* GraphicsLayerDebugInfo::clone() const
+void GraphicsLayerDebugInfo::appendAnnotatedInvalidateRects(base::trace_event::TracedValue* tracedValue) const
 {
-    GraphicsLayerDebugInfo* toReturn = new GraphicsLayerDebugInfo();
-    toReturn->setCompositingReasons(m_compositingReasons);
-    toReturn->setOwnerNodeId(m_ownerNodeId);
-    toReturn->m_invalidations = m_invalidations;
-    toReturn->m_previousInvalidations = m_previousInvalidations;
-    return toReturn;
+    tracedValue->BeginArray("annotated_invalidation_rects");
+    for (const auto& annotatedRect : m_previousInvalidations) {
+        const FloatRect& rect = annotatedRect.rect;
+        tracedValue->BeginDictionary();

[chrishtr, 2015/10/23 17:23:13]

Why these changes?

[jbroman, 2015/10/23 17:33:35]

Need to produce a base::trace_event::ConvertableToTraceValue to implement
cc::LayerClient, rather than a WebGraphicsLayerDebugInfo.
base::trace_event::TracedValue provides a convenient way of doing so, and also
removes the separate clone operation that was previously required on
GraphicsLayerDebugInfo.

[chrishtr, 2015/10/23 17:34:54]

Is base::trace_event now allowed in Blink? I think that was decided but checking
to be sure.

[jbroman, 2015/10/23 17:47:13]

My understanding is "Don't use base's TRACE_EVENT instead of Blink's, but using
base types to implement cc interfaces is now OK inside Source/platform/."

I think Elliott is working on a more long-term plan (but maybe I should add him
to this CL, too), but my reading of
https://groups.google.com/a/chromium.org/d/msg/blink-dev/kjoJSffteFc/ez3yMs8-...
suggests that people are generally OK with using base to talk to cc.

+        tracedValue->BeginArray("geometry_rect");
+        tracedValue->AppendDouble(rect.x());
+        tracedValue->AppendDouble(rect.y());
+        tracedValue->AppendDouble(rect.width());
+        tracedValue->AppendDouble(rect.height());
+        tracedValue->EndArray();
+        tracedValue->SetString("reason", paintInvalidationReasonToString(annotatedRect.reason));
+        tracedValue->EndDictionary();
+    }
+    tracedValue->EndArray();
 }
 
-void GraphicsLayerDebugInfo::appendAnnotatedInvalidateRects(JSONObject* jsonObject) const
+void GraphicsLayerDebugInfo::appendCompositingReasons(base::trace_event::TracedValue* tracedValue) const
 {
-    RefPtr<JSONArray> jsonArray = JSONArray::create();
-    for (const auto& annotatedRect : m_previousInvalidations) {
-        RefPtr<JSONObject> rectContainer = JSONObject::create();
-        RefPtr<JSONArray> rectArray = JSONArray::create();
-        const FloatRect& rect = annotatedRect.rect;
-        rectArray->pushNumber(rect.x());
-        rectArray->pushNumber(rect.y());
-        rectArray->pushNumber(rect.width());
-        rectArray->pushNumber(rect.height());
-        rectContainer->setArray("geometry_rect", rectArray);
-        rectContainer->setString("reason", paintInvalidationReasonToString(annotatedRect.reason));
-        jsonArray->pushObject(rectContainer);
-    }
-    jsonObject->setArray("annotated_invalidation_rects", jsonArray);
-}
-
-void GraphicsLayerDebugInfo::appendCompositingReasons(JSONObject* jsonObject) const
-{
-    RefPtr<JSONArray> jsonArray = JSONArray::create();
+    tracedValue->BeginArray("compositing_reasons");
     for (size_t i = 0; i < kNumberOfCompositingReasons; ++i) {
         if (!(m_compositingReasons & kCompositingReasonStringMap[i].reason))
             continue;
-        jsonArray->pushString(kCompositingReasonStringMap[i].description);
+        tracedValue->AppendString(kCompositingReasonStringMap[i].description);
     }
-    jsonObject->setArray("compositing_reasons", jsonArray);
+    tracedValue->EndArray();
 }
 
-void GraphicsLayerDebugInfo::appendDebugName(JSONObject* jsonObject) const
-{
-    if (m_debugName.isEmpty())
-        return;
-
-    jsonObject->setString("layer_name", m_debugName);
-}
-
-void GraphicsLayerDebugInfo::appendOwnerNodeId(JSONObject* jsonObject) const
+void GraphicsLayerDebugInfo::appendOwnerNodeId(base::trace_event::TracedValue* tracedValue) const
 {
     if (!m_ownerNodeId)
         return;
 
-    jsonObject->setNumber("owner_node", m_ownerNodeId);
+    tracedValue->SetInteger("owner_node", m_ownerNodeId);
 }
 
 void GraphicsLayerDebugInfo::appendAnnotatedInvalidateRect(const FloatRect& rect, PaintInvalidationReason invalidationReason)
 {
     AnnotatedInvalidationRect annotatedRect = {
         rect,
         invalidationReason
     };
     m_invalidations.append(annotatedRect);
 }
 
 void GraphicsLayerDebugInfo::clearAnnotatedInvalidateRects()
 {
     m_previousInvalidations.clear();
     m_previousInvalidations.swap(m_invalidations);
 }
 
 } // namespace blink